Changeset 29198 in webkit for trunk/JavaScriptCore/wtf/RetainPtr.h

Timestamp:

Jan 5, 2008, 2:46:03 PM (17 years ago)

Author:

Darin Adler

Message:

Rubber stamped by Maciej Stachowiak.

• cut down own PIC branches by using a pointer-to-member-data instead of a pointer-to-member-function in WTF smart pointers

• wtf/OwnArrayPtr.h:
• wtf/OwnPtr.h:
• wtf/PassRefPtr.h:
• wtf/RefPtr.h:
• wtf/RetainPtr.h: Use a pointer to the m_ptr member instead of the get member. The GCC compiler generates better code for this idiom.

File:

• trunk/JavaScriptCore/wtf/RetainPtr.h (modified) (2 diffs)

trunk/JavaScriptCore/wtf/RetainPtr.h

@@ -57 +57 @@
 #endif
 
-    template <typename T> class RetainPtr
-    {
+    template <typename T> class RetainPtr {
     public:
         typedef typename RemovePointer<T>::type ValueType;
@@ -84 +83 @@
     
         // This conversion operator allows implicit conversion to bool but not to other integer types.
-        typedef PtrType (RetainPtr::*UnspecifiedBoolType)() const;
-        operator UnspecifiedBoolType() const { return m_ptr ? &RetainPtr::get : 0; }
+        typedef T* RetainPtr::*UnspecifiedBoolType;
+        operator UnspecifiedBoolType() const { return m_ptr ? &RetainPtr::m_ptr : 0; }
         
         RetainPtr& operator=(const RetainPtr&);