Ignore:
Timestamp:
Mar 31, 2022, 6:25:02 PM (3 years ago)
Author:
Chris Dumez
Message:

Adopt Identifier::fromString(ASCIILiteral) more broadly
​https://bugs.webkit.org/show_bug.cgi?id=238574

Reviewed by Darin Adler.

Adopt Identifier::fromString(ASCIILiteral) more broadly, now that it is very efficient.

Source/JavaScriptCore:

  • API/JSBase.cpp:

(JSGetMemoryUsageStatistics):

  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Combined.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Separate.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Combined.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Separate.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Combined.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Separate.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-InternalClashingNames-Combined.js-result:
  • Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result:
  • Scripts/wkbuiltins/builtins_model.py:

(BuiltinFunction.fromString):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitThrowReferenceError):
(JSC::BytecodeGenerator::emitThrowTypeError):
(JSC::BytecodeGenerator::emitRequireObjectCoercible):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::ThrowableExpressionData::emitThrowReferenceError):

  • inspector/JSInjectedScriptHostPrototype.cpp:

(Inspector::JSInjectedScriptHostPrototype::finishCreation):

  • inspector/JSJavaScriptCallFramePrototype.cpp:

(Inspector::JSJavaScriptCallFramePrototype::finishCreation):

  • jsc.cpp:

(JSC_DEFINE_CUSTOM_SETTER):
(JSCMemoryFootprint::finishCreation):
(JSCMemoryFootprint::addProperty):
(JSC_DEFINE_HOST_FUNCTION):

  • parser/Nodes.h:
  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::finishCreation):

  • runtime/ConsoleObject.cpp:

(JSC::ConsoleObject::finishCreation):

  • runtime/Identifier.cpp:

(JSC::Identifier::add): Deleted.

  • runtime/Identifier.h:
  • runtime/IdentifierInlines.h:

(JSC::Identifier::fromCString):

  • runtime/IntlDateTimeFormatPrototype.cpp:

(JSC::IntlDateTimeFormatPrototype::finishCreation):

  • runtime/IntlNumberFormatPrototype.cpp:

(JSC::IntlNumberFormatPrototype::finishCreation):

  • runtime/IntlObject.cpp:

(JSC::IntlObject::finishCreation):

  • runtime/JSObject.cpp:

(JSC::JSObject::reifyAllStaticProperties):

  • runtime/JSObject.h:

(JSC::makeIdentifier):

  • runtime/JSObjectInlines.h:

(JSC::JSObject::getNonReifiedStaticPropertyNames):

  • runtime/JSTypedArrayViewPrototype.cpp:

(JSC::JSTypedArrayViewPrototype::finishCreation):

  • runtime/ProxyConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::ProxyConstructor::finishCreation):

  • runtime/ProxyObject.cpp:

(JSC::ProxyObject::performInternalMethodGetOwnProperty):
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::ProxyObject::performDelete):
(JSC::ProxyObject::performPreventExtensions):
(JSC::ProxyObject::performIsExtensible):
(JSC::ProxyObject::performGetOwnPropertyNames):
(JSC::ProxyObject::performSetPrototype):
(JSC::ProxyObject::performGetPrototype):

  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::finishCreation):

  • tools/JSDollarVM.cpp:

(JSC::JSDollarVM::finishCreation):
(JSC::JSDollarVM::addFunction):
(JSC::JSDollarVM::addConstructibleFunction):

  • tools/JSDollarVM.h:
  • wasm/js/JSWebAssembly.cpp:

(JSC::JSWebAssembly::finishCreation):

Source/WebCore:

  • Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.cpp:

(WebCore::CDMSessionClearKey::update):

  • bridge/testbindings.cpp:

(main):

  • bridge/testbindings.mm:

(main):

  • crypto/SubtleCrypto.cpp:

(WebCore::normalizeCryptoAlgorithmParameters):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updatePageScaleFactorJSProperty):
(WebCore::HTMLMediaElement::updateUsesLTRUserInterfaceLayoutDirectionJSProperty):
(WebCore::HTMLMediaElement::setControllerJSProperty):
(WebCore::HTMLMediaElement::setMediaControlsMaximumRightContainerButtonCountOverride):
(WebCore::HTMLMediaElement::setMediaControlsHidePlaybackRates):

  • html/HTMLMediaElement.h:
  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::addSelfToGlobalObjectInWorld):
(WebCore::InspectorFrontendHost::showContextMenu):

  • inspector/WebInjectedScriptHost.cpp:

(WebCore::constructInternalProperty):
(WebCore::objectForPaymentOptions):
(WebCore::objectForPaymentCurrencyAmount):
(WebCore::objectForPaymentItem):
(WebCore::objectForPaymentShippingOption):
(WebCore::objectForPaymentDetailsModifier):
(WebCore::objectForPaymentDetails):
(WebCore::objectForEventTargetListeners):

  • inspector/agents/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::consoleStartRecordingCanvas):

  • inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForEventListener):

  • inspector/agents/page/PageAuditAgent.cpp:

(WebCore::PageAuditAgent::populateAuditObject):

  • testing/Internals.cpp:
  • testing/Internals.h:
  • worklets/PaintWorkletGlobalScope.cpp:

(WebCore::PaintWorkletGlobalScope::registerPaint):

Source/WebKit:

  • WebProcess/WebPage/IPCTestingAPI.cpp:

(WebKit::IPCTestingAPI::jsResultFromReplyDecoder):
(WebKit::IPCTestingAPI::createJSArrayForArgumentDescriptions):
(WebKit::IPCTestingAPI::JSIPC::messages):
(WebKit::IPCTestingAPI::JSMessageListener::jsDescriptionFromDecoder):
(WebKit::IPCTestingAPI::inject):

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/tools/JSDollarVM.cpp

    r292118 r292193  
    161161        Base::finishCreation(vm);
    162162
    163         auto addProperty = [&] (VM& vm, const char* name, JSValue value) {
     163        auto addProperty = [&] (VM& vm, ASCIILiteral name, JSValue value) {
    164164            DollarVMAssertScope assertScope;
    165165            JSDollarVMCallFrame::addProperty(vm, name, value);
    … …  
    174174                return StackVisitor::Continue;
    175175
    176             addProperty(vm, "name", jsString(vm, visitor->functionName()));
     176            addProperty(vm, "name"_s, jsString(vm, visitor->functionName()));
    177177
    178178            if (visitor->callee().isCell())
    179                 addProperty(vm, "callee", visitor->callee().asCell());
     179                addProperty(vm, "callee"_s, visitor->callee().asCell());
    180180
    181181            CodeBlock* codeBlock = visitor->codeBlock();
    182182            if (codeBlock) {
    183                 addProperty(vm, "codeBlock", codeBlock);
    184                 addProperty(vm, "unlinkedCodeBlock", codeBlock->unlinkedCodeBlock());
    185                 addProperty(vm, "executable", codeBlock->ownerExecutable());
     183                addProperty(vm, "codeBlock"_s, codeBlock);
     184                addProperty(vm, "unlinkedCodeBlock"_s, codeBlock->unlinkedCodeBlock());
     185                addProperty(vm, "executable"_s, codeBlock->ownerExecutable());
    186186            }
    187187            isValid = true;
    … …  
    190190        });
    191191
    192         addProperty(vm, "valid", jsBoolean(isValid));
     192        addProperty(vm, "valid"_s, jsBoolean(isValid));
    193193    }
    194194
    … …  
    196196
    197197private:
    198     void addProperty(VM& vm, const char* name, JSValue value)
     198    void addProperty(VM& vm, ASCIILiteral name, JSValue value)
    199199    {
    200200        DollarVMAssertScope assertScope;
    … …  
    11711171    const DOMJIT::GetterSetter* domJIT = &DOMJITGetterNoEffectsDOMJIT;
    11721172    auto* customGetterSetter = DOMAttributeGetterSetter::create(vm, domJIT->getter(), nullptr, DOMAttributeAnnotation { DOMJITNode::info(), domJIT });
    1173     putDirectCustomAccessor(vm, Identifier::fromString(vm, "customGetter"), customGetterSetter, PropertyAttribute::ReadOnly | PropertyAttribute::CustomAccessor);
     1173    putDirectCustomAccessor(vm, Identifier::fromString(vm, "customGetter"_s), customGetterSetter, PropertyAttribute::ReadOnly | PropertyAttribute::CustomAccessor);
    11741174}
    11751175
    … …  
    38593859    JSGlobalObject* globalObject = this->globalObject(vm);
    38603860
    3861     auto addFunction = [&] (VM& vm, const char* name, NativeFunction function, unsigned arguments) {
     3861    auto addFunction = [&] (VM& vm, ASCIILiteral name, NativeFunction function, unsigned arguments) {
    38623862        DollarVMAssertScope assertScope;
    38633863        JSDollarVM::addFunction(vm, globalObject, name, function, arguments);
    38643864    };
    3865     auto addConstructibleFunction = [&] (VM& vm, const char* name, NativeFunction function, unsigned arguments) {
     3865    auto addConstructibleFunction = [&] (VM& vm, ASCIILiteral name, NativeFunction function, unsigned arguments) {
    38663866        DollarVMAssertScope assertScope;
    38673867        JSDollarVM::addConstructibleFunction(vm, globalObject, name, function, arguments);
    38683868    };
    38693869
    3870     addFunction(vm, "abort", functionCrash, 0);
    3871     addFunction(vm, "crash", functionCrash, 0);
    3872     addFunction(vm, "breakpoint", functionBreakpoint, 0);
     3870    addFunction(vm, "abort"_s, functionCrash, 0);
     3871    addFunction(vm, "crash"_s, functionCrash, 0);
     3872    addFunction(vm, "breakpoint"_s, functionBreakpoint, 0);
    38733873
    38743874    putDirectNativeFunction(vm, globalObject, Identifier::fromString(vm, "dfgTrue"_s), 0, functionDFGTrue, DFGTrueIntrinsic, jsDollarVMPropertyAttributes);
    … …  
    38793879    putDirectNativeFunction(vm, globalObject, Identifier::fromString(vm, "cpuCpuid"_s), 0, functionCpuCpuid, CPUCpuidIntrinsic, jsDollarVMPropertyAttributes);
    38803880    putDirectNativeFunction(vm, globalObject, Identifier::fromString(vm, "cpuPause"_s), 0, functionCpuPause, CPUPauseIntrinsic, jsDollarVMPropertyAttributes);
    3881     addFunction(vm, "cpuClflush", functionCpuClflush, 2);
    3882 
    3883     addFunction(vm, "llintTrue", functionLLintTrue, 0);
    3884     addFunction(vm, "baselineJITTrue", functionBaselineJITTrue, 0);
    3885 
    3886     addFunction(vm, "noInline", functionNoInline, 1);
    3887 
    3888     addFunction(vm, "gc", functionGC, 0);
    3889     addFunction(vm, "gcSweepAsynchronously", functionGCSweepAsynchronously, 0);
    3890     addFunction(vm, "edenGC", functionEdenGC, 0);
    3891     addFunction(vm, "dumpSubspaceHashes", functionDumpSubspaceHashes, 0);
    3892 
    3893     addFunction(vm, "callFrame", functionCallFrame, 1);
    3894     addFunction(vm, "codeBlockFor", functionCodeBlockFor, 1);
    3895     addFunction(vm, "codeBlockForFrame", functionCodeBlockForFrame, 1);
    3896     addFunction(vm, "dumpSourceFor", functionDumpSourceFor, 1);
    3897     addFunction(vm, "dumpBytecodeFor", functionDumpBytecodeFor, 1);
    3898 
    3899     addFunction(vm, "dataLog", functionDataLog, 1);
    3900     addFunction(vm, "print", functionPrint, 1);
    3901     addFunction(vm, "dumpCallFrame", functionDumpCallFrame, 0);
    3902     addFunction(vm, "dumpStack", functionDumpStack, 0);
    3903     addFunction(vm, "dumpRegisters", functionDumpRegisters, 1);
    3904 
    3905     addFunction(vm, "dumpCell", functionDumpCell, 1);
    3906 
    3907     addFunction(vm, "indexingMode", functionIndexingMode, 1);
    3908     addFunction(vm, "inlineCapacity", functionInlineCapacity, 1);
    3909     addFunction(vm, "clearLinkBufferStats", functionClearLinkBufferStats, 0);
    3910     addFunction(vm, "linkBufferStats", functionLinkBufferStats, 0);
    3911     addFunction(vm, "value", functionValue, 1);
    3912     addFunction(vm, "getpid", functionGetPID, 0);
    3913 
    3914     addFunction(vm, "haveABadTime", functionHaveABadTime, 1);
    3915     addFunction(vm, "isHavingABadTime", functionIsHavingABadTime, 1);
    3916 
    3917     addFunction(vm, "callWithStackSize", functionCallWithStackSize, 2);
    3918 
    3919     addFunction(vm, "createGlobalObject", functionCreateGlobalObject, 0);
    3920     addFunction(vm, "createProxy", functionCreateProxy, 1);
    3921     addFunction(vm, "createRuntimeArray", functionCreateRuntimeArray, 0);
    3922     addFunction(vm, "createNullRopeString", functionCreateNullRopeString, 0);
    3923 
    3924     addFunction(vm, "createImpureGetter", functionCreateImpureGetter, 1);
    3925     addFunction(vm, "createCustomGetterObject", functionCreateCustomGetterObject, 0);
    3926     addFunction(vm, "createDOMJITNodeObject", functionCreateDOMJITNodeObject, 0);
    3927     addFunction(vm, "createDOMJITGetterObject", functionCreateDOMJITGetterObject, 0);
    3928     addFunction(vm, "createDOMJITGetterNoEffectsObject", functionCreateDOMJITGetterNoEffectsObject, 0);
    3929     addFunction(vm, "createDOMJITGetterComplexObject", functionCreateDOMJITGetterComplexObject, 0);
    3930     addFunction(vm, "createDOMJITFunctionObject", functionCreateDOMJITFunctionObject, 0);
    3931     addFunction(vm, "createDOMJITCheckJSCastObject", functionCreateDOMJITCheckJSCastObject, 0);
    3932     addFunction(vm, "createDOMJITGetterBaseJSObject", functionCreateDOMJITGetterBaseJSObject, 0);
    3933     addFunction(vm, "createBuiltin", functionCreateBuiltin, 2);
     3881    addFunction(vm, "cpuClflush"_s, functionCpuClflush, 2);
     3882
     3883    addFunction(vm, "llintTrue"_s, functionLLintTrue, 0);
     3884    addFunction(vm, "baselineJITTrue"_s, functionBaselineJITTrue, 0);
     3885
     3886    addFunction(vm, "noInline"_s, functionNoInline, 1);
     3887
     3888    addFunction(vm, "gc"_s, functionGC, 0);
     3889    addFunction(vm, "gcSweepAsynchronously"_s, functionGCSweepAsynchronously, 0);
     3890    addFunction(vm, "edenGC"_s, functionEdenGC, 0);
     3891    addFunction(vm, "dumpSubspaceHashes"_s, functionDumpSubspaceHashes, 0);
     3892
     3893    addFunction(vm, "callFrame"_s, functionCallFrame, 1);
     3894    addFunction(vm, "codeBlockFor"_s, functionCodeBlockFor, 1);
     3895    addFunction(vm, "codeBlockForFrame"_s, functionCodeBlockForFrame, 1);
     3896    addFunction(vm, "dumpSourceFor"_s, functionDumpSourceFor, 1);
     3897    addFunction(vm, "dumpBytecodeFor"_s, functionDumpBytecodeFor, 1);
     3898
     3899    addFunction(vm, "dataLog"_s, functionDataLog, 1);
     3900    addFunction(vm, "print"_s, functionPrint, 1);
     3901    addFunction(vm, "dumpCallFrame"_s, functionDumpCallFrame, 0);
     3902    addFunction(vm, "dumpStack"_s, functionDumpStack, 0);
     3903    addFunction(vm, "dumpRegisters"_s, functionDumpRegisters, 1);
     3904
     3905    addFunction(vm, "dumpCell"_s, functionDumpCell, 1);
     3906
     3907    addFunction(vm, "indexingMode"_s, functionIndexingMode, 1);
     3908    addFunction(vm, "inlineCapacity"_s, functionInlineCapacity, 1);
     3909    addFunction(vm, "clearLinkBufferStats"_s, functionClearLinkBufferStats, 0);
     3910    addFunction(vm, "linkBufferStats"_s, functionLinkBufferStats, 0);
     3911    addFunction(vm, "value"_s, functionValue, 1);
     3912    addFunction(vm, "getpid"_s, functionGetPID, 0);
     3913
     3914    addFunction(vm, "haveABadTime"_s, functionHaveABadTime, 1);
     3915    addFunction(vm, "isHavingABadTime"_s, functionIsHavingABadTime, 1);
     3916
     3917    addFunction(vm, "callWithStackSize"_s, functionCallWithStackSize, 2);
     3918
     3919    addFunction(vm, "createGlobalObject"_s, functionCreateGlobalObject, 0);
     3920    addFunction(vm, "createProxy"_s, functionCreateProxy, 1);
     3921    addFunction(vm, "createRuntimeArray"_s, functionCreateRuntimeArray, 0);
     3922    addFunction(vm, "createNullRopeString"_s, functionCreateNullRopeString, 0);
     3923
     3924    addFunction(vm, "createImpureGetter"_s, functionCreateImpureGetter, 1);
     3925    addFunction(vm, "createCustomGetterObject"_s, functionCreateCustomGetterObject, 0);
     3926    addFunction(vm, "createDOMJITNodeObject"_s, functionCreateDOMJITNodeObject, 0);
     3927    addFunction(vm, "createDOMJITGetterObject"_s, functionCreateDOMJITGetterObject, 0);
     3928    addFunction(vm, "createDOMJITGetterNoEffectsObject"_s, functionCreateDOMJITGetterNoEffectsObject, 0);
     3929    addFunction(vm, "createDOMJITGetterComplexObject"_s, functionCreateDOMJITGetterComplexObject, 0);
     3930    addFunction(vm, "createDOMJITFunctionObject"_s, functionCreateDOMJITFunctionObject, 0);
     3931    addFunction(vm, "createDOMJITCheckJSCastObject"_s, functionCreateDOMJITCheckJSCastObject, 0);
     3932    addFunction(vm, "createDOMJITGetterBaseJSObject"_s, functionCreateDOMJITGetterBaseJSObject, 0);
     3933    addFunction(vm, "createBuiltin"_s, functionCreateBuiltin, 2);
    39343934#if ENABLE(WEBASSEMBLY)
    3935     addFunction(vm, "createWasmStreamingParser", functionCreateWasmStreamingParser, 0);
    3936     addFunction(vm, "createWasmStreamingCompilerForCompile", functionCreateWasmStreamingCompilerForCompile, 0);
    3937     addFunction(vm, "createWasmStreamingCompilerForInstantiate", functionCreateWasmStreamingCompilerForInstantiate, 0);
     3935    addFunction(vm, "createWasmStreamingParser"_s, functionCreateWasmStreamingParser, 0);
     3936    addFunction(vm, "createWasmStreamingCompilerForCompile"_s, functionCreateWasmStreamingCompilerForCompile, 0);
     3937    addFunction(vm, "createWasmStreamingCompilerForInstantiate"_s, functionCreateWasmStreamingCompilerForInstantiate, 0);
    39383938#endif
    3939     addFunction(vm, "createStaticCustomAccessor", functionCreateStaticCustomAccessor, 0);
    3940     addFunction(vm, "createStaticCustomValue", functionCreateStaticCustomValue, 0);
    3941     addFunction(vm, "createObjectDoingSideEffectPutWithoutCorrectSlotStatus", functionCreateObjectDoingSideEffectPutWithoutCorrectSlotStatus, 0);
    3942     addFunction(vm, "createEmptyFunctionWithName", functionCreateEmptyFunctionWithName, 1);
    3943     addFunction(vm, "getPrivateProperty", functionGetPrivateProperty, 2);
    3944     addFunction(vm, "setImpureGetterDelegate", functionSetImpureGetterDelegate, 2);
    3945 
    3946     addConstructibleFunction(vm, "Root", functionCreateRoot, 0);
    3947     addConstructibleFunction(vm, "Element", functionCreateElement, 1);
    3948     addFunction(vm, "getElement", functionGetElement, 1);
    3949 
    3950     addConstructibleFunction(vm, "SimpleObject", functionCreateSimpleObject, 0);
    3951     addFunction(vm, "getHiddenValue", functionGetHiddenValue, 1);
    3952     addFunction(vm, "setHiddenValue", functionSetHiddenValue, 2);
    3953 
    3954     addFunction(vm, "shadowChickenFunctionsOnStack", functionShadowChickenFunctionsOnStack, 0);
    3955     addFunction(vm, "setGlobalConstRedeclarationShouldNotThrow", functionSetGlobalConstRedeclarationShouldNotThrow, 0);
    3956 
    3957     addFunction(vm, "findTypeForExpression", functionFindTypeForExpression, 2);
    3958     addFunction(vm, "returnTypeFor", functionReturnTypeFor, 1);
    3959 
    3960     addFunction(vm, "flattenDictionaryObject", functionFlattenDictionaryObject, 1);
    3961 
    3962     addFunction(vm, "dumpBasicBlockExecutionRanges", functionDumpBasicBlockExecutionRanges , 0);
    3963     addFunction(vm, "hasBasicBlockExecuted", functionHasBasicBlockExecuted, 2);
    3964     addFunction(vm, "basicBlockExecutionCount", functionBasicBlockExecutionCount, 2);
    3965 
    3966     addFunction(vm, "enableDebuggerModeWhenIdle", functionEnableDebuggerModeWhenIdle, 0);
    3967     addFunction(vm, "disableDebuggerModeWhenIdle", functionDisableDebuggerModeWhenIdle, 0);
    3968 
    3969     addFunction(vm, "deleteAllCodeWhenIdle", functionDeleteAllCodeWhenIdle, 0);
    3970 
    3971     addFunction(vm, "globalObjectCount", functionGlobalObjectCount, 0);
    3972     addFunction(vm, "globalObjectForObject", functionGlobalObjectForObject, 1);
    3973 
    3974     addFunction(vm, "getGetterSetter", functionGetGetterSetter, 2);
    3975     addFunction(vm, "loadGetterFromGetterSetter", functionLoadGetterFromGetterSetter, 1);
    3976     addFunction(vm, "createCustomTestGetterSetter", functionCreateCustomTestGetterSetter, 1);
    3977 
    3978     addFunction(vm, "deltaBetweenButterflies", functionDeltaBetweenButterflies, 2);
     3939    addFunction(vm, "createStaticCustomAccessor"_s, functionCreateStaticCustomAccessor, 0);
     3940    addFunction(vm, "createStaticCustomValue"_s, functionCreateStaticCustomValue, 0);
     3941    addFunction(vm, "createObjectDoingSideEffectPutWithoutCorrectSlotStatus"_s, functionCreateObjectDoingSideEffectPutWithoutCorrectSlotStatus, 0);
     3942    addFunction(vm, "createEmptyFunctionWithName"_s, functionCreateEmptyFunctionWithName, 1);
     3943    addFunction(vm, "getPrivateProperty"_s, functionGetPrivateProperty, 2);
     3944    addFunction(vm, "setImpureGetterDelegate"_s, functionSetImpureGetterDelegate, 2);
     3945
     3946    addConstructibleFunction(vm, "Root"_s, functionCreateRoot, 0);
     3947    addConstructibleFunction(vm, "Element"_s, functionCreateElement, 1);
     3948    addFunction(vm, "getElement"_s, functionGetElement, 1);
     3949
     3950    addConstructibleFunction(vm, "SimpleObject"_s, functionCreateSimpleObject, 0);
     3951    addFunction(vm, "getHiddenValue"_s, functionGetHiddenValue, 1);
     3952    addFunction(vm, "setHiddenValue"_s, functionSetHiddenValue, 2);
     3953
     3954    addFunction(vm, "shadowChickenFunctionsOnStack"_s, functionShadowChickenFunctionsOnStack, 0);
     3955    addFunction(vm, "setGlobalConstRedeclarationShouldNotThrow"_s, functionSetGlobalConstRedeclarationShouldNotThrow, 0);
     3956
     3957    addFunction(vm, "findTypeForExpression"_s, functionFindTypeForExpression, 2);
     3958    addFunction(vm, "returnTypeFor"_s, functionReturnTypeFor, 1);
     3959
     3960    addFunction(vm, "flattenDictionaryObject"_s, functionFlattenDictionaryObject, 1);
     3961
     3962    addFunction(vm, "dumpBasicBlockExecutionRanges"_s, functionDumpBasicBlockExecutionRanges , 0);
     3963    addFunction(vm, "hasBasicBlockExecuted"_s, functionHasBasicBlockExecuted, 2);
     3964    addFunction(vm, "basicBlockExecutionCount"_s, functionBasicBlockExecutionCount, 2);
     3965
     3966    addFunction(vm, "enableDebuggerModeWhenIdle"_s, functionEnableDebuggerModeWhenIdle, 0);
     3967    addFunction(vm, "disableDebuggerModeWhenIdle"_s, functionDisableDebuggerModeWhenIdle, 0);
     3968
     3969    addFunction(vm, "deleteAllCodeWhenIdle"_s, functionDeleteAllCodeWhenIdle, 0);
     3970
     3971    addFunction(vm, "globalObjectCount"_s, functionGlobalObjectCount, 0);
     3972    addFunction(vm, "globalObjectForObject"_s, functionGlobalObjectForObject, 1);
     3973
     3974    addFunction(vm, "getGetterSetter"_s, functionGetGetterSetter, 2);
     3975    addFunction(vm, "loadGetterFromGetterSetter"_s, functionLoadGetterFromGetterSetter, 1);
     3976    addFunction(vm, "createCustomTestGetterSetter"_s, functionCreateCustomTestGetterSetter, 1);
     3977
     3978    addFunction(vm, "deltaBetweenButterflies"_s, functionDeltaBetweenButterflies, 2);
    39793979   
    3980     addFunction(vm, "currentCPUTime", functionCurrentCPUTime, 0);
    3981     addFunction(vm, "totalGCTime", functionTotalGCTime, 0);
    3982 
    3983     addFunction(vm, "parseCount", functionParseCount, 0);
    3984 
    3985     addFunction(vm, "isWasmSupported", functionIsWasmSupported, 0);
    3986     addFunction(vm, "make16BitStringIfPossible", functionMake16BitStringIfPossible, 1);
    3987 
    3988     addFunction(vm, "getStructureTransitionList", functionGetStructureTransitionList, 1);
    3989     addFunction(vm, "getConcurrently", functionGetConcurrently, 2);
    3990 
    3991     addFunction(vm, "hasOwnLengthProperty", functionHasOwnLengthProperty, 1);
    3992     addFunction(vm, "rejectPromiseAsHandled", functionRejectPromiseAsHandled, 1);
    3993 
    3994     addFunction(vm, "setUserPreferredLanguages", functionSetUserPreferredLanguages, 1);
    3995     addFunction(vm, "icuVersion", functionICUVersion, 0);
    3996     addFunction(vm, "icuHeaderVersion", functionICUHeaderVersion, 0);
    3997 
    3998     addFunction(vm, "assertEnabled", functionAssertEnabled, 0);
    3999     addFunction(vm, "securityAssertEnabled", functionSecurityAssertEnabled, 0);
    4000     addFunction(vm, "asanEnabled", functionAsanEnabled, 0);
    4001 
    4002     addFunction(vm, "isMemoryLimited", functionIsMemoryLimited, 0);
    4003     addFunction(vm, "useJIT", functionUseJIT, 0);
    4004     addFunction(vm, "isGigacageEnabled", functionIsGigacageEnabled, 0);
    4005 
    4006     addFunction(vm, "toCacheableDictionary", functionToCacheableDictionary, 1);
    4007     addFunction(vm, "toUncacheableDictionary", functionToUncacheableDictionary, 1);
    4008 
    4009     addFunction(vm, "isPrivateSymbol", functionIsPrivateSymbol, 1);
    4010     addFunction(vm, "dumpAndResetPasDebugSpectrum", functionDumpAndResetPasDebugSpectrum, 0);
    4011 
    4012     addFunction(vm, "monotonicTimeNow", functionMonotonicTimeNow, 0);
    4013     addFunction(vm, "wallTimeNow", functionWallTimeNow, 0);
    4014     addFunction(vm, "approximateTimeNow", functionApproximateTimeNow, 0);
     3980    addFunction(vm, "currentCPUTime"_s, functionCurrentCPUTime, 0);
     3981    addFunction(vm, "totalGCTime"_s, functionTotalGCTime, 0);
     3982
     3983    addFunction(vm, "parseCount"_s, functionParseCount, 0);
     3984
     3985    addFunction(vm, "isWasmSupported"_s, functionIsWasmSupported, 0);
     3986    addFunction(vm, "make16BitStringIfPossible"_s, functionMake16BitStringIfPossible, 1);
     3987
     3988    addFunction(vm, "getStructureTransitionList"_s, functionGetStructureTransitionList, 1);
     3989    addFunction(vm, "getConcurrently"_s, functionGetConcurrently, 2);
     3990
     3991    addFunction(vm, "hasOwnLengthProperty"_s, functionHasOwnLengthProperty, 1);
     3992    addFunction(vm, "rejectPromiseAsHandled"_s, functionRejectPromiseAsHandled, 1);
     3993
     3994    addFunction(vm, "setUserPreferredLanguages"_s, functionSetUserPreferredLanguages, 1);
     3995    addFunction(vm, "icuVersion"_s, functionICUVersion, 0);
     3996    addFunction(vm, "icuHeaderVersion"_s, functionICUHeaderVersion, 0);
     3997
     3998    addFunction(vm, "assertEnabled"_s, functionAssertEnabled, 0);
     3999    addFunction(vm, "securityAssertEnabled"_s, functionSecurityAssertEnabled, 0);
     4000    addFunction(vm, "asanEnabled"_s, functionAsanEnabled, 0);
     4001
     4002    addFunction(vm, "isMemoryLimited"_s, functionIsMemoryLimited, 0);
     4003    addFunction(vm, "useJIT"_s, functionUseJIT, 0);
     4004    addFunction(vm, "isGigacageEnabled"_s, functionIsGigacageEnabled, 0);
     4005
     4006    addFunction(vm, "toCacheableDictionary"_s, functionToCacheableDictionary, 1);
     4007    addFunction(vm, "toUncacheableDictionary"_s, functionToUncacheableDictionary, 1);
     4008
     4009    addFunction(vm, "isPrivateSymbol"_s, functionIsPrivateSymbol, 1);
     4010    addFunction(vm, "dumpAndResetPasDebugSpectrum"_s, functionDumpAndResetPasDebugSpectrum, 0);
     4011
     4012    addFunction(vm, "monotonicTimeNow"_s, functionMonotonicTimeNow, 0);
     4013    addFunction(vm, "wallTimeNow"_s, functionWallTimeNow, 0);
     4014    addFunction(vm, "approximateTimeNow"_s, functionApproximateTimeNow, 0);
    40154015
    40164016#if ENABLE(JIT)
    4017     addFunction(vm, "jitSizeStatistics", functionJITSizeStatistics, 0);
    4018     addFunction(vm, "dumpJITSizeStatistics", functionDumpJITSizeStatistics, 0);
    4019     addFunction(vm, "resetJITSizeStatistics", functionResetJITSizeStatistics, 0);
     4017    addFunction(vm, "jitSizeStatistics"_s, functionJITSizeStatistics, 0);
     4018    addFunction(vm, "dumpJITSizeStatistics"_s, functionDumpJITSizeStatistics, 0);
     4019    addFunction(vm, "resetJITSizeStatistics"_s, functionResetJITSizeStatistics, 0);
    40204020#endif
    40214021
    4022     addFunction(vm, "ensureArrayStorage", functionEnsureArrayStorage, 1);
     4022    addFunction(vm, "ensureArrayStorage"_s, functionEnsureArrayStorage, 1);
    40234023
    40244024    m_objectDoingSideEffectPutWithoutCorrectSlotStatusStructureID.set(vm, this, ObjectDoingSideEffectPutWithoutCorrectSlotStatus::createStructure(vm, globalObject, jsNull()));
    40254025}
    40264026
    4027 void JSDollarVM::addFunction(VM& vm, JSGlobalObject* globalObject, const char* name, NativeFunction function, unsigned arguments)
     4027void JSDollarVM::addFunction(VM& vm, JSGlobalObject* globalObject, ASCIILiteral name, NativeFunction function, unsigned arguments)
    40284028{
    40294029    DollarVMAssertScope assertScope;
    … …  
    40324032}
    40334033
    4034 void JSDollarVM::addConstructibleFunction(VM& vm, JSGlobalObject* globalObject, const char* name, NativeFunction function, unsigned arguments)
     4034void JSDollarVM::addConstructibleFunction(VM& vm, JSGlobalObject* globalObject, ASCIILiteral name, NativeFunction function, unsigned arguments)
    40354035{
    40364036    DollarVMAssertScope assertScope;
Note: See TracChangeset for help on using the changeset viewer.