Changeset 292447 in webkit for trunk/Source/JavaScriptCore/jit/JIT.cpp

Timestamp:

Apr 5, 2022, 8:41:00 PM (3 years ago)

Author:

[email protected]

Message:

[JSC] Use inlined assertion for CodeBlock type
​https://bugs.webkit.org/show_bug.cgi?id=238849

Reviewed by Michael Saboff.

We introduced probeDebug-based CodeBlock assertion, but it is too slow and causing timeout on Debug JSC tests.
Instead, we use inlined assertion which is much faster to prevent these Debug build timeout.

• assembler/AbortReason.h:
• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileEntry):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCurrentBlock):

• dfg/DFGThunks.cpp:

(JSC::DFG::osrEntryThunkGenerator):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::lower):

• jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::jitAssertCodeBlockOnCallFrameWithType):
(JSC::AssemblyHelpers::jitAssertCodeBlockOnCallFrameIsOptimizingJIT):

• jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::jitAssertCodeBlockOnCallFrameWithType):
(JSC::AssemblyHelpers::jitAssertCodeBlockOnCallFrameIsOptimizingJIT):

• jit/JIT.cpp:

(JSC::JIT::compileAndLinkWithoutFinalizing):

• jit/JITCode.h:

(JSC::JITCode::offsetOfJITType):

File:

• trunk/Source/JavaScriptCore/jit/JIT.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/jit/JIT.cpp

@@ -742 +742 @@
 
     emitFunctionPrologue();
-#if ASSERT_ENABLED
-    probeDebug([=](Probe::Context& ctx) {
-        CodeBlock* codeBlock = ctx.fp<CallFrame*>()->codeBlock();
-        if (codeBlock->jitType() != JITType::BaselineJIT) {
-            dataLogLn("FP ", RawPointer(ctx.fp<CallFrame*>()));
-            RELEASE_ASSERT_NOT_REACHED();
-        }
-    });
-#endif
+    jitAssertCodeBlockOnCallFrameWithType(regT2, JITType::BaselineJIT);
 
     Label beginLabel(this);
@@ -814 +806 @@
         emitFunctionPrologue();
         RELEASE_ASSERT(m_unlinkedCodeBlock->codeType() == FunctionCode);
-#if ASSERT_ENABLED
-        probeDebug([=](Probe::Context& ctx) {
-            CodeBlock* codeBlock = ctx.fp<CallFrame*>()->codeBlock();
-            if (codeBlock->jitType() != JITType::BaselineJIT) {
-                dataLogLn("FP ", RawPointer(ctx.fp<CallFrame*>()));
-                RELEASE_ASSERT_NOT_REACHED();
-            }
-        });
-#endif
+        jitAssertCodeBlockOnCallFrameWithType(regT2, JITType::BaselineJIT);
         emitGetFromCallFrameHeaderPtr(CallFrameSlot::codeBlock, regT0);
         store8(TrustedImm32(0), Address(regT0, CodeBlock::offsetOfShouldAlwaysBeInlined()));