Changeset 29293 in webkit for trunk/JavaScriptCore/kjs/testkjs.cpp

Timestamp:

Jan 8, 2008, 3:33:49 AM (17 years ago)

Author:

[email protected]

Message:

Turn testIsInteger assertions into compile-time asserts and move them into HashTraits.h where possible.

Reviewed by Maciej Stachowiak.

• kjs/testkjs.cpp:
• wtf/HashTraits.h:

File:

• trunk/JavaScriptCore/kjs/testkjs.cpp (modified) (4 diffs)

trunk/JavaScriptCore/kjs/testkjs.cpp

@@ -54 +54 @@
 using namespace WTF;
 
-static void testIsInteger();
 static bool fillBufferWithContentsOfFile(const UString& fileName, Vector<char>& buffer);
 
@@ -118 +117 @@
   virtual UString className() const { return "global"; }
 };
+COMPILE_ASSERT(!IsInteger<GlobalImp>::value, WTF_IsInteger_GlobalImp_false);
 
 class TestFunctionImp : public JSObject {
@@ -303 +303 @@
 int kjsmain(int argc, char** argv)
 {
-  testIsInteger();
-
   JSLock lock;
   
@@ -318 +316 @@
 
   return success ? 0 : 3;
-}
-
-static void testIsInteger()
-{
-  // Unit tests for WTF::IsInteger. Don't have a better place for them now.
-  // FIXME: move these once we create a unit test directory for WTF.
-
-  ASSERT(IsInteger<bool>::value);
-  ASSERT(IsInteger<char>::value);
-  ASSERT(IsInteger<signed char>::value);
-  ASSERT(IsInteger<unsigned char>::value);
-  ASSERT(IsInteger<short>::value);
-  ASSERT(IsInteger<unsigned short>::value);
-  ASSERT(IsInteger<int>::value);
-  ASSERT(IsInteger<unsigned int>::value);
-  ASSERT(IsInteger<long>::value);
-  ASSERT(IsInteger<unsigned long>::value);
-  ASSERT(IsInteger<long long>::value);
-  ASSERT(IsInteger<unsigned long long>::value);
-
-  ASSERT(!IsInteger<char*>::value);
-  ASSERT(!IsInteger<const char* >::value);
-  ASSERT(!IsInteger<volatile char* >::value);
-  ASSERT(!IsInteger<double>::value);
-  ASSERT(!IsInteger<float>::value);
-  ASSERT(!IsInteger<GlobalImp>::value);
 }