Changeset 293497 in webkit for trunk/Source/WebCore/rendering/RenderLineBreak.cpp

Timestamp:

Apr 26, 2022, 10:30:42 PM (3 years ago)

Author:

Antti Koivisto

Message:

::first-letter does not work if used only in shadow content
​https://bugs.webkit.org/show_bug.cgi?id=220650
<rdar://problem/73477161>

Reviewed by Alan Bujtas.

Source/WebCore:

Test: fast/shadow-dom/shadow-first-line-and-letter.html

We were not setting usesFirstLetter/LinesRules bits if those pseudo-elements were used
only in shadow trees.

Fix by removing the bits. They don't seem to allow any valuable optimizations.

• rendering/LegacyRootInlineBox.cpp:

(WebCore::LegacyRootInlineBox::verticalPositionForBox):

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::lineHeight const):
(WebCore::RenderBlock::getFirstLetter):

• rendering/RenderInline.cpp:

(WebCore::RenderInline::mayAffectLayout const):
(WebCore::RenderInline::lineHeight const):

• rendering/RenderLineBreak.cpp:

(WebCore::RenderLineBreak::lineHeight const):

• rendering/RenderView.h:
• style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
(WebCore::Style::TreeResolver::resolve):

LayoutTests:

Test case by ​[email protected].

• fast/shadow-dom/shadow-first-line-and-letter-expected.html: Added.
• fast/shadow-dom/shadow-first-line-and-letter.html: Added.

File:

• trunk/Source/WebCore/rendering/RenderLineBreak.cpp (modified) (1 diff)

trunk/Source/WebCore/rendering/RenderLineBreak.cpp

@@ -67 +67 @@
 LayoutUnit RenderLineBreak::lineHeight(bool firstLine, LineDirectionMode /*direction*/, LinePositionMode /*linePositionMode*/) const
 {
-    if (firstLine && view().usesFirstLineRules()) {
+    if (firstLine) {
         const RenderStyle& firstLineStyle = this->firstLineStyle();
         if (&firstLineStyle != &style())