Changeset 293588 in webkit for trunk/Source/JavaScriptCore/jsc.cpp

Timestamp:

Apr 28, 2022, 1:13:57 PM (3 years ago)

Author:

Chris Dumez

Message:

Leverage the known length of an ASCIILiteral when comparing it to a String / AtomString
​https://bugs.webkit.org/show_bug.cgi?id=239798

Reviewed by Yusuke Suzuki and Darin Adler.

Leverage the known length of an ASCIILiteral when comparing it to a String / AtomString.
Make sure we call ASCIILiteral::length() inline to allow the compiler to optimize out
the strlen() call, then call the more efficient equal(StringImpl*, const LChar*, unsigned)
instead of equal(StringImpl*, const LChar*).

• Source/JavaScriptCore/jsc.cpp:

(printInternal):

• Source/JavaScriptCore/runtime/JSCJSValueInlines.h:

(JSC::toPreferredPrimitiveType):

• Source/JavaScriptCore/runtime/PropertyName.h:

(JSC::isCanonicalNumericIndexString):

• Source/WTF/wtf/text/AtomString.h:

(WTF::operator==):

• Source/WTF/wtf/text/StringImpl.h:

(WTF::equal):

• Source/WTF/wtf/text/WTFString.h:

(WTF::operator==):
(WTF::operator!=):

Canonical link: ​https://commits.webkit.org/250097@main

File:

• trunk/Source/JavaScriptCore/jsc.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/jsc.cpp

@@ -1279 +1279 @@
     if (asyncTestExpectedPasses) {
         JSValue value = callFrame->argument(0);
-        if (value.isString() && WTF::equal(asString(value)->value(globalObject).impl(), "Test262:AsyncTestComplete")) {
+        if (value.isString() && WTF::equal(asString(value)->value(globalObject).impl(), "Test262:AsyncTestComplete"_s)) {
             asyncTestPasses++;
             return JSValue::encode(jsUndefined());