Changeset 293779 in webkit for trunk/Source/JavaScriptCore/jsc.cpp

Timestamp:

May 4, 2022, 10:44:44 AM (3 years ago)

Author:

[email protected]

Message:

Use IterationStatus in more places.
​https://bugs.webkit.org/show_bug.cgi?id=239864

Reviewed by Saam Barati.

Source/JavaScriptCore:

There's no need for a StackVisitor::Status and a VMInspector::FunctorStatus which
represent the same idea.

• API/JSContextRef.cpp:

(BacktraceFunctor::operator() const):

• bytecode/CodeBlock.cpp:

(JSC::RecursionCheckFunctor::operator() const):

• debugger/DebuggerCallFrame.cpp:

(JSC::LineAndColumnFunctor::operator() const):

• inspector/ScriptCallStackFactory.cpp:

(Inspector::CreateScriptCallStackFunctor::operator() const):

• interpreter/CallFrame.cpp:

(JSC::CallFrame::callerSourceOrigin):
(JSC::CallFrame::globalObjectOfClosestCodeBlock):

• interpreter/CallFrame.h:
• interpreter/Interpreter.cpp:

(JSC::GetStackTraceFunctor::operator() const):
(JSC::Interpreter::getStackTrace):
(JSC::GetCatchHandlerFunctor::operator() const):
(JSC::UnwindFunctor::operator() const):

• interpreter/ShadowChicken.cpp:

(JSC::ShadowChicken::update):

• interpreter/StackVisitor.h:

(JSC::StackVisitor::visit):
(JSC::CallerFunctor::operator() const):

• jsc.cpp:

(FunctionJSCStackFunctor::operator() const):
(startTimeoutTimer):

• runtime/Error.cpp:

(JSC::FindFirstCallerFrameWithCodeblockFunctor::operator() const):

• runtime/FunctionPrototype.cpp:

(JSC::RetrieveArgumentsFunctor::operator() const):
(JSC::RetrieveCallerFunctionFunctor::operator() const):

• runtime/JSGlobalObject.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

• runtime/NullSetterFunction.cpp:

(JSC::GetCallerStrictnessFunctor::operator() const):

• tools/HeapVerifier.cpp:

(JSC::HeapVerifier::checkIfRecorded):

• tools/JSDollarVM.cpp:

(JSC::CallerFrameJITTypeFunctor::operator() const):
(JSC::JSC_DEFINE_HOST_FUNCTION):

• tools/VMInspector.cpp:

(JSC::VMInspector::forEachVM):
(JSC::VMInspector::isValidExecutableMemory):
(JSC::VMInspector::codeBlockForMachinePC):
(JSC::VMInspector::codeBlockForFrame):
(JSC::DumpFrameFunctor::operator() const):
(JSC::VMInspector::dumpRegisters):

• tools/VMInspector.h:

(JSC::VMInspector::WTF_REQUIRES_LOCK):

Source/WebCore:

• bindings/js/JSDOMGlobalObject.cpp:

(WebCore::callerGlobalObject):

• testing/Internals.cpp:

(WebCore::GetCallerCodeBlockFunctor::operator() const):

File:

• trunk/Source/JavaScriptCore/jsc.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/jsc.cpp

@@ -1377 +1377 @@
     }
 
-    StackVisitor::Status operator()(StackVisitor& visitor) const
+    IterationStatus operator()(StackVisitor& visitor) const
     {
         m_trace.append(makeString("    ", visitor->index(), "   ", visitor->toString(), '\n'));
-        return StackVisitor::Continue;
+        return IterationStatus::Continue;
     }
 
@@ -2937 +2937 @@
     Thread::create("jsc Timeout Thread", [=] () {
         sleep(duration);
-        VMInspector::forEachVM([&] (VM& vm) -> VMInspector::FunctorStatus {
+        VMInspector::forEachVM([&] (VM& vm) -> IterationStatus {
             if (&vm != s_vm)
-                return VMInspector::FunctorStatus::Continue;
+                return IterationStatus::Continue;
             vm.notifyNeedShellTimeoutCheck();
-            return VMInspector::FunctorStatus::Done;
+            return IterationStatus::Done;
         });