Changeset 293879 in webkit for trunk/Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp

Timestamp:

May 5, 2022, 7:34:31 PM (3 years ago)

Author:

Chris Dumez

Message:

Identifier::string() should return an AtomString
​https://bugs.webkit.org/show_bug.cgi?id=240122

Reviewed by Yusuke Suzuki.

Identifier::string() should return an AtomString instead of a String, since
it holds an AtomString internally.

Also add some overloads to jsString() to resolve ambiguity for some callers.

• Source/JavaScriptCore/API/JSContext.mm:

(-[JSContext dependencyIdentifiersForModuleJSScript:]):

• Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:

(JSC::processClauseList):

• Source/JavaScriptCore/dfg/DFGOperations.cpp:

(JSC::DFG::JSC_DEFINE_JIT_OPERATION):

• Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::functionDetails):

• Source/JavaScriptCore/jsc.cpp:

(JSC_DEFINE_HOST_FUNCTION):

• Source/JavaScriptCore/runtime/Error.cpp:

(JSC::addErrorInfo):

• Source/JavaScriptCore/runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::finishCreation):

• Source/JavaScriptCore/runtime/ErrorPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

• Source/JavaScriptCore/runtime/FunctionExecutable.cpp:

(JSC::FunctionExecutable::toStringSlow):

• Source/JavaScriptCore/runtime/Identifier.h:

(JSC::Identifier::string const):
(JSC::Identifier::atomString const): Deleted.

• Source/JavaScriptCore/runtime/IdentifierInlines.h:

(JSC::identifierToJSValue):
(JSC::identifierToSafePublicJSValue):

• Source/JavaScriptCore/runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::format const):
(JSC::IntlDateTimeFormat::formatRange):

• Source/JavaScriptCore/runtime/IntlDisplayNames.cpp:

(JSC::IntlDisplayNames::of const):

• Source/JavaScriptCore/runtime/IntlListFormat.cpp:

(JSC::IntlListFormat::format const):

• Source/JavaScriptCore/runtime/IntlRelativeTimeFormat.cpp:

(JSC::IntlRelativeTimeFormat::format const):

• Source/JavaScriptCore/runtime/JSFunction.cpp:

(JSC::JSFunction::reifyName):

• Source/JavaScriptCore/runtime/JSModuleLoader.cpp:

(JSC::JSModuleLoader::requestImportModule):

• Source/JavaScriptCore/runtime/JSString.h:

(JSC::jsString):

• Source/JavaScriptCore/runtime/JSStringInlines.h:

(JSC::repeatCharacter):

• Source/JavaScriptCore/runtime/StringPrototype.cpp:

(JSC::jsSpliceSubstrings):
(JSC::jsSpliceSubstringsWithSeparators):
(JSC::toLocaleCase):
(JSC::normalize):

• Source/JavaScriptCore/runtime/SymbolPrototype.cpp:

(JSC::JSC_DEFINE_CUSTOM_GETTER):

• Source/WTF/wtf/PrintStream.cpp:

(WTF::printInternal):

• Source/WTF/wtf/PrintStream.h:
• Source/WebCore/animation/KeyframeEffect.cpp:

(WebCore::processKeyframeLikeObject):

• Source/WebCore/inspector/WebInjectedScriptHost.cpp:

(WebCore::WebInjectedScriptHost::getInternalProperties):

Canonical link: ​https://commits.webkit.org/250337@main

File:

• trunk/Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp

@@ -4461 +4461 @@
                 break;
             }
-            const String& value = static_cast<StringNode*>(clauseExpression)->value().string();
+            auto& value = static_cast<StringNode*>(clauseExpression)->value().string();
             if (singleCharacterSwitch &= value.length() == 1) {
                 int32_t intVal = value[0];