Ignore:
Timestamp:
Jan 11, 2008, 1:52:27 AM (17 years ago)
Author:
[email protected]
Message:

JavaScriptCore:

Reviewed by John Sullivan.

Fixed some world leak reports:

  • <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript Interpreter after running cvs-base suite
  • <rdar://problem/5669423> PLT complains about world leak if browser window is open when PLT starts


  • kjs/collector.h: Added the ability to distinguish between global objects and GC-protected global objects, since we only consider the latter to be world leaks.
  • kjs/collector.cpp:

WebCore:

Reviewed by John Sullivan.

Fixed some world leak reports:

  • <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript Interpreter after running cvs-base suite
  • <rdar://problem/5669423> PLT complains about world leak if browser window is open when PLT starts


These were both bugs in the reporting mechanism, so I took the
opportunity to do some house cleaning there.

Stupid class, I kill you:

  • bridge/JavaScriptStatistics.cpp: Removed.
  • bridge/JavaScriptStatistics.h: Removed.
  • bindings/js/GCController.h: Adopted the only useful features of JavaScriptStatistics, since they were GC-related.
  • bindings/js/GCController.cpp:

WebKit/mac:

Reviewed by John Sullivan.

Fixed some world leak reports:

  • <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript Interpreter after running cvs-base suite
  • <rdar://problem/5669423> PLT complains about world leak if browser window is open when PLT starts


These were both bugs in the reporting mechanism, so I took the
opportunity to do some house cleaning there.

  • Misc/WebCoreStatistics.h: Did a little renaming, to match JavaScriptCore better. I kept the methods with the old names around, though, because old versions of Safari need them.
  • Misc/WebCoreStatistics.mm: Removed dependence on WebCore::JavaScriptStatistics, which is gone now.


These two methods are now distinct, for the sake of world leak reporting:
(+[WebCoreStatistics javaScriptGlobalObjectsCount]):
(+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):

WebKit/win:

Reviewed by John Sullivan.

Updated for transition away from JavaScriptStatistics, which is gone now.

  • WebJavaScriptCollector.cpp: (WebJavaScriptCollector::collect): (WebJavaScriptCollector::collectOnAlternateThread): (WebJavaScriptCollector::objectCount):

WebKitTools:

Reviewed by John Sullivan.

  • DumpRenderTree/mac/GCControllerMac.mm: (GCController::collectOnAlternateThread): Updated for name change.
File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/JavaScriptCore/JavaScriptCore.exp

    r29067 r29396  
    223223__ZN3KJS8jsStringERKNS_7UStringE
    224224__ZN3KJS9Collector15recordExtraCostEm
    225 __ZN3KJS9Collector16numGlobalObjectsEv
    226 __ZN3KJS9Collector19numProtectedObjectsEv
    227 __ZN3KJS9Collector20rootObjectTypeCountsEv
     225__ZN3KJS9Collector17globalObjectCountEv
     226__ZN3KJS9Collector20protectedObjectCountEv
    228227__ZN3KJS9Collector23collectOnMainThreadOnlyEPNS_7JSValueE
     228__ZN3KJS9Collector25protectedObjectTypeCountsEv
     229__ZN3KJS9Collector26protectedGlobalObjectCountEv
    229230__ZN3KJS9Collector4sizeEv
    230231__ZN3KJS9Collector7collectEv
Note: See TracChangeset for help on using the changeset viewer.