Changeset 294101 in webkit for trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp

Timestamp:

May 12, 2022, 6:49:11 AM (3 years ago)

Author:

Oriol Brufau

Message:

[cssom] Serialize computed '-webkit-text-combine: none'
​https://bugs.webkit.org/show_bug.cgi?id=239989

Reviewed by Tim Nguyen.

LayoutTests/imported/w3c:

Update some test expectations.

• web-platform-tests/css/cssom/serialize-all-longhands-expected.txt:

Source/WebCore:

The computed value of '-webkit-text-combine' was only serialized for
'-webkit-text-combine: horizontal' or 'text-combine-upright: all'.

But the initial value 'none' just produced an empty string.

Test: imported/w3c/web-platform-tests/css/cssom/serialize-all-longhands.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):

File:

• trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (modified) (1 diff)

trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp

@@ -3970 +3970 @@
             if (style.textCombine() == TextCombine::All)
                 return CSSPrimitiveValue::createIdentifier(CSSValueHorizontal);
-            return nullptr;
+            return cssValuePool.createValue(style.textCombine());
         case CSSPropertyTextCombineUpright:
             return cssValuePool.createValue(style.textCombine());