Changeset 294468 in webkit for trunk/Source/JavaScriptCore/tools/FunctionOverrides.cpp

Timestamp:

May 18, 2022, 10:53:40 PM (3 years ago)

Author:

Chris Dumez

Message:

Add find()/reverseFind()/contains() overloads takes an ASCIILiteral to our String types ​https://bugs.webkit.org/show_bug.cgi?id=240247
​https://bugs.webkit.org/show_bug.cgi?id=240247

Reviewed by Darin Adler.

Add find()/reverseFind()/contains() overloads takes an ASCIILiteral to our String types.
These versions are more efficient when the call sites have an ASCIILiteral as they have
less branching.

• Source/JavaScriptCore/runtime/ExceptionHelpers.cpp:

(JSC::notAFunctionSourceAppender):
(JSC::invalidParameterInSourceAppender):
(JSC::invalidParameterInstanceofSourceAppender):
(JSC::invalidPrototypeSourceAppender):

• Source/JavaScriptCore/runtime/IntlObject.cpp:

(JSC::canonicalizeUnicodeExtensionsAfterICULocaleCanonicalization):
(JSC::lookupMatcher):

• Source/JavaScriptCore/tools/FunctionOverrides.cpp:

(JSC::initializeOverrideInfo):

• Source/WebCore/PAL/pal/text/DecodeEscapeSequences.h:

(PAL::Unicode16BitEscapeSequence::findInString):

• Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:

(WebKit::needsNewCreateTableSchema):
(WebKit::ResourceLoadStatisticsDatabaseStore::insertDomainRelationshipList):

• Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponse):

• Source/WebKit/NetworkProcess/cache/PrefetchCache.cpp:

(WebKit::PrefetchCache::take):

• Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _updateTextInputTraits:]):

• Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::focusedElementInformation):

• Source/WebKit/WebProcess/WebProcess.cpp:

(WebKit::checkDocumentsCaptureStateConsistency):

• Source/WebKitLegacy/mac/WebView/WebView.mm:

(-[WebView updateTextTouchBar]):

• Source/WTF/wtf/text/AtomString.h:
• Source/WTF/wtf/text/StringImpl.cpp:

(WTF::StringImpl::find):
(WTF::StringImpl::reverseFind):

• Source/WTF/wtf/text/StringImpl.h:

(WTF::StringImpl::find):
(WTF::StringImpl::reverseFind):

• Source/WTF/wtf/text/StringView.cpp:

(WTF::StringView::find const):
(WTF::StringView::reverseFind const):

• Source/WTF/wtf/text/StringView.h:
• Source/WTF/wtf/text/WTFString.h:
• Source/WebCore/Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::FetchBodyConsumer::packageFormData):

• Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::validateSDP const):
(WebCore::PeerConnectionBackend::newICECandidate):

• Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:

(WebCore::YouTubePluginReplacement::youTubeURLFromAbsoluteURL):

• Source/WebCore/dom/DataTransfer.cpp:

(WebCore::DataTransfer::types const):

• Source/WebCore/dom/Document.cpp:

(WebCore::Document::createCDATASection):
(WebCore::Document::createProcessingInstruction):

• Source/WebCore/editing/cocoa/HTMLConverter.mm:

(HTMLConverter::computedAttributesForElement):

• Source/WebCore/editing/libwpe/EditorLibWPE.cpp:

(WebCore::createFragmentFromPasteboardData):

• Source/WebCore/editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::shouldPreserveMSOListStyleForElement):
(WebCore::StyledMarkupAccumulator::appendNodeToPreserveMSOList):
(WebCore::shouldPreserveMSOLists):

• Source/WebCore/html/track/VTTRegion.cpp:

(WebCore::VTTRegion::parseSettingValue):

• Source/WebCore/html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::collectWebVTTBlock):
(WebCore::WebVTTParser::checkAndRecoverCue):
(WebCore::WebVTTParser::checkAndCreateRegion):
(WebCore::WebVTTParser::checkAndStoreRegion):
(WebCore::WebVTTParser::checkStyleSheet):
(WebCore::WebVTTParser::checkAndStoreStyleSheet):
(WebCore::WebVTTParser::collectCueId):
(WebCore::WebVTTParser::collectCueText):
(WebCore::WebVTTParser::ignoreBadCue):

• Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:

(WebCore::GStreamerRegistryScanner::ElementFactories::hasElementForMediaType const):

• Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

• Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.cpp:

(WebCore::ExtensionsGLOpenGLCommon::ExtensionsGLOpenGLCommon):

• Source/WebCore/platform/graphics/texmap/TextureMapperContextAttributes.cpp:

(WebCore::TextureMapperContextAttributes::get):

• Source/WebCore/platform/ios/UserAgentIOS.mm:

(WebCore::deviceNameForUserAgent):

• Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:

(WebCore::isValidCaptureDevice):

• Source/WebCore/rendering/style/GridPositionsResolver.cpp:

(WebCore::NamedLineCollectionBase::NamedLineCollectionBase):

• Source/WebCore/style/StyleScope.cpp:

(WebCore::Style::Scope::collectActiveStyleSheets):

• Source/WebCore/testing/Internals.cpp:

(WebCore::Internals::isVP9VTBDeccoderUsed):

• Source/WebCore/testing/MockLibWebRTCPeerConnection.cpp:

(WebCore::MockLibWebRTCPeerConnection::SetRemoteDescription):

Canonical link: ​https://commits.webkit.org/250730@main

File:

• trunk/Source/JavaScriptCore/tools/FunctionOverrides.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/tools/FunctionOverrides.cpp

@@ -131 +131 @@
     String origProviderStr = origCode.provider()->source().toString();
     unsigned origStart = origCode.startOffset();
-    unsigned origFunctionStart = origProviderStr.reverseFind("function", origStart);
+    unsigned origFunctionStart = origProviderStr.reverseFind("function"_s, origStart);
     unsigned origBraceStart = origProviderStr.find('{', origStart);
     unsigned headerLength = origBraceStart - origFunctionStart;