Changeset 29986 in webkit for trunk/JavaScriptCore

Timestamp:

Feb 4, 2008, 7:25:59 PM (17 years ago)

Author:

[email protected]

Message:

Fix ​http://bugs.webkit.org/show_bug.cgi?id=17175 (Bug 17175: Use of C++ compiler flags in CFLAGS).

Reviewed by Alp Toker and Mark Rowe.

Add global_cxxflags definition for inclusion in CXXFLAGS variables.
Only use -fno-rtti and $(SYMBOL_VISIBILITY_INLINES) with global_cxxflags as gcc complains they aren't valid for C.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (2 diffs)
• GNUmakefile.am (modified) (2 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-02-04  Rodney Dawes  <[email protected]>
+
+        Reviewed by Alp Toker and Mark Rowe.
+
+        Fix http://bugs.webkit.org/show_bug.cgi?id=17175.
+        Bug 17175: Use of C++ compiler flags in CFLAGS
+
+        * GNUmakefile.am: Use global_cxxflags as well as global_cflags in CXXFLAGS.
+
 2008-02-04  Alp Toker  <[email protected]>
 
@@ -18 +27 @@
         putting things into the back/forward cache. If that's true, then this
         should fix the problem.
-        
+
         (According to Geoff's measurements, in a PLT that exaggerates the
         importance of symbol table saving during cached page creation, this

trunk/JavaScriptCore/GNUmakefile.am

@@ -150 +150 @@
         JavaScriptCore/API/minidom.c
 Programs_minidom_CPPFLAGS = $(global_cppflags)
-Programs_minidom_CXXFLAGS = $(global_cflags)
+Programs_minidom_CXXFLAGS = $(global_cxxflags) $(global_cflags)
 Programs_minidom_LDADD = libJavaScriptCore.la
 Programs_minidom_LDFLAGS = -rpath $(CURDIR)/.libs
@@ -157 +157 @@
 Programs_testkjs_SOURCES = JavaScriptCore/kjs/testkjs.cpp
 Programs_testkjs_CPPFLAGS = $(global_cppflags)
-Programs_testkjs_CXXFLAGS = $(global_cflags)
+Programs_testkjs_CXXFLAGS = $(global_cxxflags) $(global_cflags)
 Programs_testkjs_LDADD = libJavaScriptCore.la
 Programs_testkjs_LDFLAGS = -rpath $(CURDIR)/.libs