Changeset 29991 in webkit for trunk/JavaScriptCore

Timestamp:

Feb 4, 2008, 9:51:58 PM (17 years ago)

Author:

[email protected]

Message:

2008-02-04 Cameron McCormack <​[email protected]>

Reviewed by Geoff Garen.

Remove some unneccesary UNUSED_PARAMs. Clarify ownership rule of return value of JSObjectCopyPropertyNames.

• API/JSNode.c: (JSNode_appendChild): (JSNode_removeChild): (JSNode_replaceChild): (JSNode_getNodeType): (JSNode_getFirstChild):
• API/JSNodeList.c: (JSNodeList_length):
• API/JSObjectRef.h:

Location:

trunk/JavaScriptCore

Files:

• API/JSNode.c (modified) (5 diffs)
• API/JSNodeList.c (modified) (1 diff)
• API/JSObjectRef.h (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/JavaScriptCore/API/JSNode.c

@@ -37 +37 @@
 static JSValueRef JSNode_appendChild(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
 {
-    UNUSED_PARAM(context);
     UNUSED_PARAM(function);
 
@@ -61 +60 @@
 static JSValueRef JSNode_removeChild(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
 {
-    UNUSED_PARAM(context);
     UNUSED_PARAM(function);
     
@@ -81 +79 @@
 static JSValueRef JSNode_replaceChild(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
 {
-    UNUSED_PARAM(context);
     UNUSED_PARAM(function);
     
@@ -110 +107 @@
 static JSValueRef JSNode_getNodeType(JSContextRef context, JSObjectRef object, JSStringRef propertyName, JSValueRef* exception)
 {
-    UNUSED_PARAM(context);
     UNUSED_PARAM(propertyName);
     UNUSED_PARAM(exception);
@@ -137 +133 @@
 static JSValueRef JSNode_getFirstChild(JSContextRef context, JSObjectRef object, JSStringRef propertyName, JSValueRef* exception)
 {
-    UNUSED_PARAM(context);
+    UNUSED_PARAM(object);
     UNUSED_PARAM(propertyName);
-    UNUSED_PARAM(object);
     UNUSED_PARAM(exception);
     

trunk/JavaScriptCore/API/JSNodeList.c

@@ -54 +54 @@
 static JSValueRef JSNodeList_length(JSContextRef context, JSObjectRef thisObject, JSStringRef propertyName, JSValueRef* exception)
 {
-    UNUSED_PARAM(context);
     UNUSED_PARAM(propertyName);
     UNUSED_PARAM(exception);

trunk/JavaScriptCore/API/JSObjectRef.h

@@ -595 +595 @@
 @param ctx The execution context to use.
 @param object The object whose property names you want to get.
-@result A JSPropertyNameArray containing the names object's enumerable properties.
+@result A JSPropertyNameArray containing the names object's enumerable properties. Ownership follows the Create Rule.
 */
 JS_EXPORT JSPropertyNameArrayRef JSObjectCopyPropertyNames(JSContextRef ctx, JSObjectRef object);

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-02-04  Cameron McCormack <[email protected]>
+
+        Reviewed by Geoff Garen.
+
+        Remove some unneccesary UNUSED_PARAMs.  Clarify ownership rule of return value of JSObjectCopyPropertyNames.
+
+        * API/JSNode.c:
+        (JSNode_appendChild):
+        (JSNode_removeChild):
+        (JSNode_replaceChild):
+        (JSNode_getNodeType):
+        (JSNode_getFirstChild):
+        * API/JSNodeList.c:
+        (JSNodeList_length):
+        * API/JSObjectRef.h:
+
 2008-02-04  Rodney Dawes  <[email protected]>