Changeset 30040 in webkit for trunk/JavaScriptCore/kjs/string_object.cpp

Timestamp:

Feb 6, 2008, 9:33:07 AM (17 years ago)

Author:

Darin Adler

Message:

JavaScriptCore:

Reviewed by Sam.

• replace calls to put to set up properties with calls to putDirect, to prepare for a future change where put won't take attributes any more, and for a slight performance boost

• API/JSObjectRef.cpp: (JSObjectMakeConstructor): Use putDirect instead of put.
• kjs/CommonIdentifiers.h: Removed lastIndex.
• kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::reset): Use putDirect instead of put.
• kjs/array_object.cpp: (KJS::arrayProtoFuncConcat): Took out extra call to get length (unused). (KJS::ArrayObjectImp::ArrayObjectImp): Use putDirect instead of put.
• kjs/error_object.cpp: (KJS::ErrorPrototype::ErrorPrototype): Use putDirect instead of put.
• kjs/function.cpp: (KJS::Arguments::Arguments): Use putDirect instead of put. (KJS::PrototypeFunction::PrototypeFunction): Use putDirect instead of put.
• kjs/function_object.cpp: (KJS::FunctionObjectImp::construct): Use putDirect instead of put.
• kjs/nodes.cpp: (KJS::FuncDeclNode::makeFunction): Use putDirect instead of put. (KJS::FuncExprNode::evaluate): Use putDirect instead of put.
• kjs/regexp_object.cpp: (KJS::regExpProtoFuncCompile): Use setLastIndex instead of put(lastIndex). (KJS::RegExpImp::match): Get and set lastIndex by using m_lastIndex instead of calling get and put.
• kjs/regexp_object.h: (KJS::RegExpImp::setLastIndex): Added.
• kjs/string_object.cpp: (KJS::stringProtoFuncMatch): Use setLastIndex instead of put(lastIndex).

WebCore:

Reviewed by Sam.

• replace calls to put to set up properties with calls to putDirect, to prepare for a future change where put won't take attributes any more, and for a slight performance boost

• bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor): Use putDirect instead of put.
• bindings/js/JSEventTargetBase.h: (WebCore::JSEventTargetPrototype::self): Ditto.
• bindings/js/JSHTMLOptionElementConstructor.cpp: (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor): Ditto.
• bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item): Ditto.

File:

• trunk/JavaScriptCore/kjs/string_object.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/string_object.cpp

@@ -569 +569 @@
       }
       if (imp)
-        imp->put(exec, exec->propertyNames().lastIndex, jsNumber(lastIndex), DontDelete|DontEnum);
+        imp->setLastIndex(lastIndex);
       if (list.isEmpty()) {
         // if there are no matches at all, it's important to return