Changeset 30102 in webkit for trunk/JavaScriptCore/kjs/function_object.cpp

Timestamp:

Feb 8, 2008, 5:06:23 PM (17 years ago)

Author:

Darin Adler

Message:

JavaScriptCore:

Reviewed by Eric.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=15003 Function.prototype.constructor should not be DontDelete/ReadOnly (Acid3 bug)

Test: fast/js/constructor-attributes.html

• kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::reset): Remove unwanted attributes from "constructor".
• kjs/function_object.cpp: (KJS::FunctionObjectImp::construct): Ditto.
• kjs/nodes.cpp: (KJS::FuncDeclNode::makeFunction): Ditto. (KJS::FuncExprNode::evaluate): Ditto.

WebCore:

Reviewed by Eric.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=15003 Function.prototype.constructor should not be DontDelete/ReadOnly (Acid3 bug)

Test: fast/js/constructor-attributes.html

• bindings/scripts/CodeGeneratorJS.pm: Remove unwanted attributes from "constructor".

LayoutTests:

Reviewed by Eric.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=15003 Function.prototype.constructor should not be DontDelete/ReadOnly (Acid3 bug)

• fast/js/constructor-attributes-expected.txt: Added.
• fast/js/constructor-attributes.html: Added.
• fast/js/resources/constructor-attributes.js: Added.

File:

• trunk/JavaScriptCore/kjs/function_object.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/function_object.cpp

@@ -225 +225 @@
     JSObject* objCons = exec->lexicalGlobalObject()->objectConstructor();
     JSObject* prototype = objCons->construct(exec, exec->emptyList());
-    prototype->putDirect(exec->propertyNames().constructor, fimp, DontEnum | DontDelete | ReadOnly);
+    prototype->putDirect(exec->propertyNames().constructor, fimp, DontEnum);
     fimp->putDirect(exec->propertyNames().prototype, prototype, Internal | DontDelete);
     return fimp;