Changeset 30109 in webkit for trunk/JavaScriptCore/kjs/nodes.h

Timestamp:

Feb 9, 2008, 10:09:42 AM (17 years ago)

Author:

Darin Adler

Message:

Reviewed by Mitz.

• ​http://bugs.webkit.org/show_bug.cgi?id=17256 Change RegExp to start its ref count at 1, not 0

We'll want to do this to every RefCounted class, one at a time.

• kjs/nodes.h: (KJS::RegExpNode::RegExpNode): Use RegExp::create instead of new RegExp.
• kjs/regexp.cpp: (KJS::RegExp::RegExp): Marked inline, set initial ref count to 1. (KJS::RegExp::create): Added. Calls new RegExp then adopts the initial ref.
• kjs/regexp.h: Reformatted. Made the constructors private. Added static create functions that return objects already wrapped in PassRefPtr.
• kjs/regexp_object.cpp: (KJS::regExpProtoFuncCompile): Use RegExp::create instead of new RegExp. (KJS::RegExpObjectImp::construct): Ditto.
• kjs/string_object.cpp: (KJS::stringProtoFuncMatch): Ditto. (KJS::stringProtoFuncSearch): Ditto.

File:

• trunk/JavaScriptCore/kjs/nodes.h (modified) (1 diff)

trunk/JavaScriptCore/kjs/nodes.h

@@ -335 +335 @@
     public:
         RegExpNode(const UString& pattern, const UString& flags) KJS_FAST_CALL
-            : m_regExp(new RegExp(pattern, flags))
+            : m_regExp(RegExp::create(pattern, flags))
         {
         }