Changeset 30380 in webkit for trunk/JavaScriptCore

Timestamp:

Feb 18, 2008, 1:28:21 PM (17 years ago)

Author:

Darin Adler

Message:

Reviewed by Sam.

• wtf/ASCIICType.h: (WTF::toASCIIHexValue): Added.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• wtf/ASCIICType.h (modified) (2 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-02-18  Darin Adler  <[email protected]>
+
+        Reviewed by Sam.
+
+        * wtf/ASCIICType.h:
+        (WTF::toASCIIHexValue): Added.
+
 2008-02-17  Darin Adler  <[email protected]>
 

trunk/JavaScriptCore/wtf/ASCIICType.h

@@ -87 +87 @@
 
     /*
-        Statistics from a run of the PLT on the usage of isASCIISpace:
-        Hex  Name               Count
-        ---  ----               -----
-           ALL OTHER VALUES     689383
-        x20  SPACE              294720
-        x0A  NEWLINE            89059
-        x09  TAB                28320
-        x0D  CARRIAGE RETURN    0
-        x0C  FORMFEED           0
-        x0B  VERTICAL TAB       0
+        Statistics from a run of Apple's page load test for callers of isASCIISpace:
 
+            character          count
+            ---------          -----
+            non-spaces         689383
+        20  space              294720
+        0A  \n                 89059
+        09  \t                 28320
+        0D  \r                 0
+        0C  \f                 0
+        0B  \v                 0
     */
-
     inline bool isASCIISpace(char c) { return c <= ' ' && (c == ' ' || (c <= 0xD && c >= 0x9)); }
     inline bool isASCIISpace(unsigned short c) { return c <= ' ' && (c == ' ' || (c <= 0xD && c >= 0x9)); }
@@ -121 +120 @@
     inline int toASCIIUpper(int c) { return static_cast<int>(c & ~((c >= 'a' && c <= 'z') << 5)); }
 
+    inline int toASCIIHexValue(char c) { ASSERT(isASCIIHexDigit(c)); return c < 'A' ? c - '0' : (c - 'A' + 10) & 0xF; }
+    inline int toASCIIHexValue(unsigned short c) { ASSERT(isASCIIHexDigit(c)); return c < 'A' ? c - '0' : (c - 'A' + 10) & 0xF; }
+#if !COMPILER(MSVC) || defined(_NATIVE_WCHAR_T_DEFINED)
+    inline int toASCIIHexValue(wchar_t c) { ASSERT(isASCIIHexDigit(c)); return c < 'A' ? c - '0' : (c - 'A' + 10) & 0xF; }
+#endif
+    inline int toASCIIHexValue(int c) { ASSERT(isASCIIHexDigit(c)); return c < 'A' ? c - '0' : (c - 'A' + 10) & 0xF; }
+
 }