Changeset 30387 in webkit for trunk/JavaScriptCore

Timestamp:

Feb 18, 2008, 4:25:26 PM (17 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

Reviewed by Geoff Garen.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=17419
Remove CompatMode from JavaScriptCore as it is never set to anything other than NativeMode

• kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init):
• kjs/JSGlobalObject.h: (KJS::JSGlobalObject::setDebugger):
• kjs/date_object.cpp: (KJS::dateProtoFuncGetYear):

WebCore:

Reviewed by Geoff Garen.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=17419
Remove CompatMode from JavaScriptCore as it is never set to anything other than NativeMode

• bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScript):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• kjs/JSGlobalObject.cpp (modified) (1 diff)
• kjs/JSGlobalObject.h (modified) (3 diffs)
• kjs/date_object.cpp (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-02-18  Samuel Weinig  <[email protected]>
+
+        Reviewed by Geoff Garen.
+
+        Fix for http://bugs.webkit.org/show_bug.cgi?id=17419
+        Remove CompatMode from JavaScriptCore as it is never set to anything other than NativeMode
+
+        * kjs/JSGlobalObject.cpp:
+        (KJS::JSGlobalObject::init):
+        * kjs/JSGlobalObject.h:
+        (KJS::JSGlobalObject::setDebugger):
+        * kjs/date_object.cpp:
+        (KJS::dateProtoFuncGetYear):
+
 2008-02-18  Darin Adler  <[email protected]>
 

trunk/JavaScriptCore/kjs/JSGlobalObject.cpp

@@ -131 +131 @@
         s_head = d()->next = d()->prev = this;
 
-    d()->compatMode = NativeMode;
-
     resetTimeoutCheck();
     d()->timeoutTime = 0;

trunk/JavaScriptCore/kjs/JSGlobalObject.h

@@ -68 +68 @@
     struct ActivationStackNode;
 
-    enum CompatMode { NativeMode, IECompat, NetscapeCompat };
-
     class JSGlobalObject : public JSVariableObject {
     protected:
@@ -85 +83 @@
 
             Debugger* debugger;
-            CompatMode compatMode;
             
             GlobalExecState globalExec;
@@ -210 +207 @@
         Debugger* debugger() const { return d()->debugger; }
         void setDebugger(Debugger* debugger) { d()->debugger = debugger; }
-
-        // FIXME: Let's just pick one compatible behavior and go with it.
-        void setCompatMode(CompatMode mode) { d()->compatMode = mode; }
-        CompatMode compatMode() const { return d()->compatMode; }
         
         int recursion() { return d()->recursion; }

trunk/JavaScriptCore/kjs/date_object.cpp

@@ -1607 +1607 @@
     msToGregorianDateTime(milli, utc, t);
 
-    // IE returns the full year even in getYear.
-    if (exec->dynamicGlobalObject()->compatMode() == IECompat)
-        return jsNumber(1900 + t.year);
+    // NOTE: IE returns the full year even in getYear.
     return jsNumber(t.year);
 }