Changeset 30593 in webkit for trunk/JavaScriptCore/wtf/Vector.h

Timestamp:

Feb 26, 2008, 9:06:24 AM (17 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

Reviewed by Dan Bernstein.

• Add a variant of remove that takes a position and a length.

• wtf/Vector.h: (WTF::Vector::remove):

WebCore:

Reviewed by Dan Bernstein.

Make the cleanPath function in CSSStyleSelector more efficient by using
a Vector<UChar>.

• css/CSSStyleSelector.cpp: (WebCore::cleanPath): Make this function work on a Vector<UChar> instead of a String. Also remove unnecessary reverseFind call that could be acomplished with two compares. (WebCore::checkPseudoState): Remove reserveCapacity calls now that we are using a stack buffer.
• platform/text/PlatformString.h: (WebCore::find): Make this find generic enough that it can be used for String::find. (WebCore::reverseFind): Implement reverseFind so that it can be used for with a UChar* and length.
• platform/text/StringImpl.cpp: (WebCore::StringImpl::find): Use implementation in PlatformString.cpp (WebCore::StringImpl::reverseFind): Ditto,

File:

• trunk/JavaScriptCore/wtf/Vector.h (modified) (2 diffs)

trunk/JavaScriptCore/wtf/Vector.h

@@ -473 +473 @@
 
         void remove(size_t position);
+        void remove(size_t position, size_t length);
 
         void removeLast() 
@@ -776 +777 @@
 
     template<typename T, size_t inlineCapacity>
+    inline void Vector<T, inlineCapacity>::remove(size_t position, size_t length)
+    {
+        ASSERT(position < size());
+        ASSERT(position + length < size());
+        T* beginSpot = begin() + position;
+        T* endSpot = beginSpot + length;
+        TypeOperations::destruct(beginSpot, endSpot); 
+        TypeOperations::moveOverlapping(endSpot, end(), beginSpot);
+        m_size -= length;
+    }
+
+    template<typename T, size_t inlineCapacity>
     inline T* Vector<T, inlineCapacity>::releaseBuffer()
     {