Changeset 30651 in webkit for trunk/JavaScriptCore/kjs/nodes.cpp

Timestamp:

Feb 28, 2008, 2:16:46 PM (17 years ago)

Author:

[email protected]

Message:

Reviewed by Geoffrey Garen.

TOTAL : 1.005x as fast 2867.6ms +/- 0.4% 2853.2ms +/- 0.3% significant

• kjs/nodes.cpp: Tell the compiler that exceptions are unexpected (for the sake of branch prediction and code organization).

File:

• trunk/JavaScriptCore/kjs/nodes.cpp (modified) (4 diffs)

trunk/JavaScriptCore/kjs/nodes.cpp

@@ -51 +51 @@
 };
 
+#if COMPILER(GCC)
+#define UNLIKELY(x) \
+  __builtin_expect ((x), 0)
+#else
+#define UNLIKELY(x) x
+#endif
+    
 #define KJS_CHECKEXCEPTION \
-if (exec->hadException()) \
+if (UNLIKELY(exec->hadException())) \
     return rethrowException(exec);
 
 #define KJS_CHECKEXCEPTIONVALUE \
-if (exec->hadException()) { \
+if (UNLIKELY(exec->hadException())) { \
     handleException(exec); \
     return jsUndefined(); \
@@ -62 +69 @@
 
 #define KJS_CHECKEXCEPTIONNUMBER \
-if (exec->hadException()) { \
+if (UNLIKELY(exec->hadException())) { \
     handleException(exec); \
     return 0; \
@@ -68 +75 @@
 
 #define KJS_CHECKEXCEPTIONBOOLEAN \
-if (exec->hadException()) { \
+if (UNLIKELY(exec->hadException())) { \
     handleException(exec); \
     return false; \
@@ -74 +81 @@
 
 #define KJS_CHECKEXCEPTIONVOID \
-if (exec->hadException()) { \
+if (UNLIKELY(exec->hadException())) { \
     handleException(exec); \
     return; \