Changeset 30942 in webkit for trunk/JavaScriptCore/kjs/identifier.cpp

Timestamp:

Mar 10, 2008, 3:06:44 PM (17 years ago)

Author:

[email protected]

Message:

Reviewed by Darin.

Remove KJS::UChar, use ::UChar instead
​http://bugs.webkit.org/show_bug.cgi?id=17017

To functional changes, thus no tests.

• bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::hasCSSPropertyNamePrefix): (WebCore::cssPropertyName):
• bindings/js/JSDOMWindowBase.cpp: (WebCore::windowProtoFuncAToB): (WebCore::windowProtoFuncBToA):
• bindings/js/JSSVGPODTypeWrapper.h:
• bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate):
• bridge/objc/objc_utility.mm: (KJS::Bindings::throwError):
• dom/Document.cpp: (WebCore::Document::parseQualifiedName):
• platform/text/AtomicString.cpp: (WebCore::AtomicString::add):
• platform/text/String.cpp: (WebCore::String::String): (WebCore::String::operator Identifier): (WebCore::String::operator UString):
• platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::decode):
• svg/SVGAnimatedTemplate.h:

File:

• trunk/JavaScriptCore/kjs/identifier.cpp (modified) (4 diffs)

trunk/JavaScriptCore/kjs/identifier.cpp

@@ -68 +68 @@
     const UChar *d = r->data();
     for (int i = 0; i != length; ++i)
-        if (d[i].uc != (unsigned char)s[i])
+        if (d[i] != (unsigned char)s[i])
             return false;
     return s[length] == 0;
@@ -79 +79 @@
     const UChar *d = r->data();
     for (int i = 0; i != length; ++i)
-        if (d[i].uc != s[i].uc)
+        if (d[i] != s[i])
             return false;
     return true;
@@ -92 +92 @@
     const UChar *s = b->data();
     for (int i = 0; i != length; ++i)
-        if (d[i].uc != s[i].uc)
+        if (d[i] != s[i])
             return false;
     return true;
@@ -114 +114 @@
         UChar *d = static_cast<UChar *>(fastMalloc(sizeof(UChar) * length));
         for (size_t i = 0; i != length; i++)
-            d[i] = c[i];
+            d[i] = static_cast<unsigned char>(c[i]); // use unsigned char to zero-extend instead of sign-extend
         
         UString::Rep *r = UString::Rep::create(d, static_cast<int>(length)).releaseRef();