Changeset 30942 in webkit for trunk/JavaScriptCore/kjs/nodes2string.cpp

Timestamp:

Mar 10, 2008, 3:06:44 PM (17 years ago)

Author:

[email protected]

Message:

Reviewed by Darin.

Remove KJS::UChar, use ::UChar instead
​http://bugs.webkit.org/show_bug.cgi?id=17017

To functional changes, thus no tests.

• bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::hasCSSPropertyNamePrefix): (WebCore::cssPropertyName):
• bindings/js/JSDOMWindowBase.cpp: (WebCore::windowProtoFuncAToB): (WebCore::windowProtoFuncBToA):
• bindings/js/JSSVGPODTypeWrapper.h:
• bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate):
• bridge/objc/objc_utility.mm: (KJS::Bindings::throwError):
• dom/Document.cpp: (WebCore::Document::parseQualifiedName):
• platform/text/AtomicString.cpp: (WebCore::AtomicString::add):
• platform/text/String.cpp: (WebCore::String::String): (WebCore::String::operator Identifier): (WebCore::String::operator UString):
• platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::decode):
• svg/SVGAnimatedTemplate.h:

File:

• trunk/JavaScriptCore/kjs/nodes2string.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/nodes2string.cpp

@@ -79 +79 @@
 
     for (int i = 0; i < s.size(); i++) {
-        unsigned short c = s.data()[i].unicode();
+        unsigned short c = s.data()[i];
         switch (c) {
             case '\"':
@@ -160 +160 @@
     m_numberNeedsParens = false;
     m_atStartOfStatement = false;
-    UChar ch(c);
+    // use unsigned char to zero-extend instead of sign-extend
+    UChar ch(static_cast<unsigned char>(c));
     m_string.append(ch);
     return *this;