Changeset 31225 in webkit for trunk/JavaScriptCore/kjs/JSVariableObject.h

Timestamp:

Mar 21, 2008, 7:36:34 PM (17 years ago)

Author:

[email protected]

Message:

Global properties that use LocalStorage are not correctly listed as enumerable.

Reviewed by Geoff Garen

The problem was caused by JSObject::getPropertyAttributes not being aware
of the JSVariableObject SymbolTable. The fix is to make getPropertyAttributes
virtual and override in JSVariableObject. This does not produce any performance
regression.

File:

• trunk/JavaScriptCore/kjs/JSVariableObject.h (modified) (2 diffs)

trunk/JavaScriptCore/kjs/JSVariableObject.h

@@ -38 +38 @@
     class JSVariableObject : public JSObject {
     public:
-        SymbolTable& symbolTable() { return *d->symbolTable; }
-        LocalStorage& localStorage() { return d->localStorage; }
+        SymbolTable& symbolTable() const { return *d->symbolTable; }
+        LocalStorage& localStorage() const { return d->localStorage; }
         
         void saveLocalStorage(SavedProperties&) const;
@@ -53 +53 @@
         virtual bool isVariableObject() const;
         virtual bool isDynamicScope() const = 0;
+
+        virtual bool getPropertyAttributes(const Identifier& propertyName, unsigned& attributes) const;
 
     protected: