Changeset 31270 in webkit for trunk/JavaScriptCore/kjs/JSImmediate.cpp

Timestamp:

Mar 24, 2008, 8:39:56 PM (17 years ago)

Author:

Darin Adler

Message:

2008-03-24 Darin Adler <Darin Adler>

Reviewed by Sam.

• convert a JavaScript immediate number to a string more efficiently

2% speedup of Acid3 test 26

• kjs/JSImmediate.cpp: (KJS::JSImmediate::toString): Take advantage of the fact that all immediate numbers are integers, and use the faster UString function for formatting integers instead of the slower one that works for floating point. I think this is a leftover from when immediate numbers were floating point.

File:

• trunk/JavaScriptCore/kjs/JSImmediate.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/JSImmediate.cpp

@@ -1 +1 @@
 /*
- *  This file is part of the KDE libraries
- *  Copyright (C) 2003-2006 Apple Computer, Inc
+ *  Copyright (C) 2003-2006, 2008 Apple Inc. All rights reserved.
  *
  *  This library is free software; you can redistribute it and/or
@@ -49 +48 @@
 }
 
-UString JSImmediate::toString(const JSValue *v)
+UString JSImmediate::toString(const JSValue* v)
 {
     ASSERT(isImmediate(v));
-    
     if (v == jsNull())
         return "null";
-    else if (v == jsUndefined())
+    if (v == jsUndefined())
         return "undefined";
-    else if (v == jsBoolean(true))
+    if (v == jsBoolean(true))
         return "true";
-    else if (v == jsBoolean(false))
+    if (v == jsBoolean(false))
         return "false";
-    else {
-        ASSERT(isNumber(v));
-        double d = toDouble(v);
-        if (d == 0.0) // +0.0 or -0.0
-            return "0";
-        return UString::from(d);
-    }
+    ASSERT(isNumber(v));
+    return UString::from(getTruncatedInt32(v));
 }