Changeset 31319 in webkit for trunk/JavaScriptCore/kjs/identifier.h

Timestamp:

Mar 26, 2008, 10:44:59 AM (17 years ago)

Author:

[email protected]

Message:

Reviewed by Darin.

Cache C string identifiers by address, not value, assuming that C strings can only
be literals.

1% speedup on Acid3 test 26.

• kjs/identifier.cpp: (KJS::literalIdentifierTable): (KJS::Identifier::add): Added a new table to cache UString::Reps created from C strings by address. Elements are never removed from this cache, as only predefined identifiers can get there.

• kjs/identifier.h: (KJS::Identifier::Identifier): Added a warning.

File:

• trunk/JavaScriptCore/kjs/identifier.h (modified) (1 diff)

trunk/JavaScriptCore/kjs/identifier.h

@@ -30 +30 @@
     public:
         Identifier() { }
-        Identifier(const char* s) : _ustring(add(s)) { }
+        Identifier(const char* s) : _ustring(add(s)) { } // Only to be used with string literals.
         Identifier(const UChar* s, int length) : _ustring(add(s, length)) { }
         explicit Identifier(UString::Rep* rep) : _ustring(add(rep)) { }