Changeset 31872 in webkit for trunk/JavaScriptCore/API/JSClassRef.cpp

Timestamp:

Apr 14, 2008, 11:48:16 AM (17 years ago)

Author:

[email protected]

Message:

2008-04-14 Anders Carlsson <​[email protected]>

Reviewed by Adam.

Don't leak the prototype class.

• API/JSClassRef.cpp: (OpaqueJSClass::create):

File:

• trunk/JavaScriptCore/API/JSClassRef.cpp (modified) (1 diff)

trunk/JavaScriptCore/API/JSClassRef.cpp

@@ -118 +118 @@
         protoDefinition.staticFunctions = staticFunctions;
         protoDefinition.finalize = clearReferenceToPrototype;
-        OpaqueJSClass* protoClass = new OpaqueJSClass(&protoDefinition, 0);
+        
+        // We are supposed to use JSClassRetain/Release but since we know that we currently have
+        // the only reference to this class object we cheat and use a RefPtr instead.
+        RefPtr<OpaqueJSClass> protoClass = adoptRef(new OpaqueJSClass(&protoDefinition, 0));
 
         // remove functions from the original class
         JSClassDefinition objectDefinition = *definition;
         objectDefinition.staticFunctions = 0;
-        return adoptRef(new OpaqueJSClass(&objectDefinition, protoClass));
+
+        return adoptRef(new OpaqueJSClass(&objectDefinition, protoClass.get()));
     }