Changeset 31936 in webkit for trunk/JavaScriptCore/kjs/CommonIdentifiers.cpp

Timestamp:

Apr 16, 2008, 2:30:01 AM (17 years ago)

Author:

[email protected]

Message:

Reviewed by Darin.

Implement an abstraction for thread-specific storage, use it to get rid of some static objects.

SunSpider results were not conclusive, possibly up to 0.2% slowdown.

• JavaScriptCore.xcodeproj/project.pbxproj:
• JavaScriptCore.vcproj/WTF/WTF.vcproj: Added ThreadSpecific.h

• wtf/ThreadSpecific.h: Added. (WTF::::ThreadSpecific): (WTF::::~ThreadSpecific): (WTF::::get): (WTF::::set): (WTF::::destroy): (WTF::T): (WTF::::operator): Only implemented for platforms that use pthreads.

• kjs/CommonIdentifiers.cpp: (KJS::CommonIdentifiers::shared):
• kjs/CommonIdentifiers.h:
• kjs/InitializeThreading.cpp: (KJS::initializeThreading):
• kjs/Parser.cpp: (KJS::parser):
• kjs/Parser.h:
• kjs/identifier.cpp: (KJS::identifierTable): (KJS::literalIdentifierTable): (KJS::Identifier::initializeIdentifierThreading):
• kjs/identifier.h:
• kjs/lexer.cpp: (KJS::lexer):
• kjs/lexer.h: Make static instances per-thread.

File:

• trunk/JavaScriptCore/kjs/CommonIdentifiers.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/CommonIdentifiers.cpp

@@ -22 +22 @@
 #include "CommonIdentifiers.h"
 
+#if USE(MULTIPLE_THREADS)
+#include <wtf/ThreadSpecific.h>
+#endif
+
 namespace KJS {
 
@@ -37 +41 @@
 CommonIdentifiers* CommonIdentifiers::shared()
 {
-    static CommonIdentifiers* sharedInstance;
-    if (!sharedInstance) {
-        JSLock lock;
-        sharedInstance = new CommonIdentifiers;
-    }
+#if USE(MULTIPLE_THREADS)
+    static ThreadSpecific<CommonIdentifiers> sharedInstance;
     return sharedInstance;
+#else
+    static CommonIdentifiers sharedInstance;
+    return &sharedInstance;
+#endif
 }