Changeset 31937 in webkit for trunk/JavaScriptCore/kjs/date_object.h

Timestamp:

Apr 16, 2008, 2:41:23 AM (17 years ago)

Author:

[email protected]

Message:

Reviewed by Adam Roben.

Cache Gregorian date/time structure on DateInstance objects for 1.027x SunSpider speedup
(1.65x on date-format-xparb, 1.13x on date-format-tofte).

• kjs/DateMath.h: (KJS::GregorianDateTime::copyFrom): Added. It presumably makes sense to keep GregorianDateTime Noncopiable, so it's not just operator=.

• kjs/date_object.h: Added a per-object cache.

• kjs/date_object.cpp: (KJS::DateInstance::DateInstance): (KJS::DateInstance::msToGregorianDateTime): (KJS::dateProtoFuncToString): (KJS::dateProtoFuncToUTCString): (KJS::dateProtoFuncToDateString): (KJS::dateProtoFuncToTimeString): (KJS::dateProtoFuncToLocaleString): (KJS::dateProtoFuncToLocaleDateString): (KJS::dateProtoFuncToLocaleTimeString): (KJS::dateProtoFuncGetFullYear): (KJS::dateProtoFuncGetUTCFullYear): (KJS::dateProtoFuncToGMTString): (KJS::dateProtoFuncGetMonth): (KJS::dateProtoFuncGetUTCMonth): (KJS::dateProtoFuncGetDate): (KJS::dateProtoFuncGetUTCDate): (KJS::dateProtoFuncGetDay): (KJS::dateProtoFuncGetUTCDay): (KJS::dateProtoFuncGetHours): (KJS::dateProtoFuncGetUTCHours): (KJS::dateProtoFuncGetMinutes): (KJS::dateProtoFuncGetUTCMinutes): (KJS::dateProtoFuncGetSeconds): (KJS::dateProtoFuncGetUTCSeconds): (KJS::dateProtoFuncGetTimezoneOffset): (KJS::setNewValueFromTimeArgs): (KJS::setNewValueFromDateArgs): (KJS::dateProtoFuncSetYear): (KJS::dateProtoFuncGetYear): Use the cache when converting.

File:

• trunk/JavaScriptCore/kjs/date_object.h (modified) (4 diffs)

trunk/JavaScriptCore/kjs/date_object.h

@@ -22 +22 @@
 #define DATE_OBJECT_H
 
+#include "DateMath.h"
 #include "function.h"
 #include "JSWrapperObject.h"
@@ -27 +28 @@
 
 namespace KJS {
-
-    struct GregorianDateTime;
 
     class FunctionPrototype;
@@ -36 +35 @@
     public:
         DateInstance(JSObject *proto);
+        virtual ~DateInstance();
         
         bool getTime(GregorianDateTime&, int& offset) const;
@@ -44 +44 @@
         virtual const ClassInfo *classInfo() const { return &info; }
         static const ClassInfo info;
+
+        void msToGregorianDateTime(double, bool outputIsUTC, GregorianDateTime&) const;
+
+    private:
+        struct Cache {
+            double m_gregorianDateTimeCachedForMS;
+            GregorianDateTime m_cachedGregorianDateTime;
+            double m_gregorianDateTimeUTCCachedForMS;
+            GregorianDateTime m_cachedGregorianDateTimeUTC;
+        };
+
+        mutable Cache* m_cache;
     };