Changeset 32652 in webkit for trunk/JavaScriptCore/kjs/ExecState.cpp

Timestamp:

Apr 28, 2008, 11:22:14 AM (17 years ago)

Author:

[email protected]

Message:

Reviewed by Darin.

Fix run-webkit-tests --threading
and provisionally fix <​https://bugs.webkit.org/show_bug.cgi?id=18661>
Proxy server issue in Sunday's Nightly

Changed ClassInfo objects for built-in objects to hold a getter function returning
a per-thread instance. This makes it safe to share these ClassInfo objects between threads -
and these are the only ones that need to be shared.

File:

• trunk/JavaScriptCore/kjs/ExecState.cpp (modified) (4 diffs)

trunk/JavaScriptCore/kjs/ExecState.cpp

@@ -34 +34 @@
 namespace KJS {
 
-static inline List* globalEmptyList()
-{
-    static List staticEmptyList;
-    return &staticEmptyList;
-}
-
 // ECMA 10.2
 
@@ -46 +40 @@
     : m_globalObject(globalObject)
     , m_exception(0)
-    , m_propertyNames(CommonIdentifiers::shared())
-    , m_emptyList(globalEmptyList())
     , m_callingExec(0)
+    , m_perThreadData(globalObject->perThreadData())
     , m_scopeNode(0)
     , m_function(0)
@@ -68 +61 @@
     : m_globalObject(globalObject)
     , m_exception(0)
-    , m_propertyNames(CommonIdentifiers::shared())
-    , m_emptyList(globalEmptyList())
     , m_callingExec(0)
+    , m_perThreadData(globalObject->perThreadData())
     , m_scopeNode(programNode)
     , m_function(0)
@@ -91 +83 @@
     : m_globalObject(globalObject)
     , m_exception(0)
-    , m_propertyNames(callingExec->m_propertyNames)
-    , m_emptyList(callingExec->m_emptyList)
     , m_callingExec(callingExec)
+    , m_perThreadData(callingExec->m_perThreadData)
     , m_scopeNode(evalNode)
     , m_function(0)