Changeset 32693 in webkit for trunk/JavaScriptCore/profiler/FunctionCallProfile.cpp

Timestamp:

Apr 29, 2008, 11:09:04 AM (17 years ago)

Author:

[email protected]

Message:

2008-04-29 Kevin McCullough <​[email protected]>

Reviewed by Geoff.

-<rdar://problem/5770054> JavaScript profiler (10928)
-Keep call count.

• profiler/FunctionCallProfile.cpp: (KJS::FunctionCallProfile::FunctionCallProfile): (KJS::FunctionCallProfile::didExecute): Implements call count and fixed a bug where a stackIndex of 0 was causing the assert to be hit. (KJS::FunctionCallProfile::stopProfiling): (KJS::FunctionCallProfile::endAndRecordCall):
• profiler/FunctionCallProfile.h:

File:

• trunk/JavaScriptCore/profiler/FunctionCallProfile.cpp (modified) (4 diffs)

trunk/JavaScriptCore/profiler/FunctionCallProfile.cpp

@@ -40 +40 @@
     : m_functionName(name)
     , m_timeSum(0)
+    , m_numberOfCalls(0)
 {
     m_startTime = getCurrentUTCTime();
@@ -57 +58 @@
 void FunctionCallProfile::didExecute(Vector<UString> stackNames, unsigned int stackIndex)
 {
-    if (stackIndex == stackNames.size()) {
+    if (stackIndex && stackIndex == stackNames.size()) {
         ASSERT(stackNames[stackIndex - 1] == m_functionName);
-
-        m_timeSum += getCurrentUTCTime() - m_startTime;
-        m_startTime = 0.0;
-
-        // FIXME: We may need something with higher resolution than ms as some functions will take 0ms.
+        endAndRecordCall();
         return;
     }
@@ -101 +98 @@
 {
     if (m_startTime)
-        m_timeSum += getCurrentUTCTime() - m_startTime;
+        endAndRecordCall();
 
     StackIterator endOfChildren = m_children.end();
@@ -160 +157 @@
 }
 
+void FunctionCallProfile::endAndRecordCall()
+{
+    m_timeSum += getCurrentUTCTime() - m_startTime;
+    m_startTime = 0.0;
+
+    ++m_numberOfCalls;
+}
+
 }   // namespace KJS