Changeset 33007 in webkit for trunk/JavaScriptCore/profiler/Profiler.cpp

Timestamp:

May 9, 2008, 1:18:08 PM (17 years ago)

Author:

[email protected]

Message:

2008-05-09 Kevin McCullough <​[email protected]>

Reviewed by Tim.

-<rdar://problem/5770054> JavaScript profiler (10928)
-Add Profile class so that all profiles can be stored and retrieved by
the WebInspector when that time comes.

• JavaScriptCore.exp: Export the new function signatures.
• JavaScriptCore.xcodeproj/project.pbxproj: Add the new files to the project
• profiler/Profile.cpp: Added. This class represents a single run of the profiler. (KJS::Profile::Profile): (KJS::Profile::willExecute): (KJS::Profile::didExecute): (KJS::Profile::printDataInspectorStyle): (KJS::functionNameCountPairComparator): (KJS::Profile::printDataSampleStyle):
• profiler/Profile.h: Added. Ditto (KJS::Profile::stopProfiling):
• profiler/Profiler.cpp: Now the profiler keeps track of many profiles but only runs one at a time. (KJS::Profiler::startProfiling): (KJS::Profiler::stopProfiling): (KJS::Profiler::willExecute): (KJS::Profiler::didExecute): (KJS::Profiler::printDataInspectorStyle): (KJS::Profiler::printDataSampleStyle):
• profiler/Profiler.h: Ditto. (KJS::Profiler::~Profiler): (KJS::Profiler::allProfiles): (KJS::Profiler::clearProfiles):

File:

• trunk/JavaScriptCore/profiler/Profiler.cpp (modified) (9 diffs)

trunk/JavaScriptCore/profiler/Profiler.cpp

@@ -30 +30 @@
 #include "Profiler.h"
 
+#include "ExecState.h"
+#include "function.h"
 #include "FunctionCallProfile.h"
 #include "JSGlobalObject.h"
-#include "ExecState.h"
-#include "function.h"
+#include "Profile.h"
 
 #include <stdio.h>
@@ -54 +55 @@
 }
 
-void Profiler::startProfiling(unsigned pageGroupIdentifier)
+void Profiler::startProfiling(unsigned pageGroupIdentifier, const UString& title)
 {
     if (m_profiling)
@@ -61 +62 @@
     m_pageGroupIdentifier = pageGroupIdentifier;
 
-    // FIXME: When multi-threading is supported this will be a vector and calls
-    // into the profiler will need to know which thread it is executing on.
-    m_callTree.set(new FunctionCallProfile("Thread_1"));
+    m_currentProfile.set(new Profile(title));
     m_profiling = true;
 }
@@ -70 +69 @@
 {
     m_profiling = false;
-    m_callTree->stopProfiling();
+
+    if (!m_currentProfile)
+        return;
+
+    m_currentProfile->stopProfiling();
+    m_allProfiles.append(m_currentProfile.release());
 }
 
@@ -80 +84 @@
     Vector<UString> callStackNames;
     getStackNames(callStackNames, exec, calledFunction);
-    insertStackNamesInTree(callStackNames);
+    m_currentProfile->willExecute(callStackNames);
 }
 
@@ -90 +94 @@
     Vector<UString> callStackNames;
     getStackNames(callStackNames, exec, sourceURL, startingLineNumber);
-    insertStackNamesInTree(callStackNames);
+    m_currentProfile->willExecute(callStackNames);
 }
 
@@ -100 +104 @@
     Vector<UString> callStackNames;
     getStackNames(callStackNames, exec, calledFunction);
-    m_callTree->didExecute(callStackNames, 0);
+    m_currentProfile->didExecute(callStackNames);
 }
 
@@ -110 +114 @@
     Vector<UString> callStackNames;
     getStackNames(callStackNames, exec, sourceURL, startingLineNumber);
-    m_callTree->didExecute(callStackNames, 0);
-}
-
-void Profiler::insertStackNamesInTree(const Vector<UString>& callStackNames)
-{
-    FunctionCallProfile* callTreeInsertionPoint = 0;
-    FunctionCallProfile* foundNameInTree = m_callTree.get();
-    NameIterator callStackLocation = callStackNames.begin();
-
-    while (callStackLocation != callStackNames.end() && foundNameInTree) {
-        callTreeInsertionPoint = foundNameInTree;
-        foundNameInTree = callTreeInsertionPoint->findChild(*callStackLocation);
-        ++callStackLocation;
-    }
-
-    if (!foundNameInTree) {   // Insert remains of the stack into the call tree.
-        --callStackLocation;
-        for (FunctionCallProfile* next; callStackLocation != callStackNames.end(); ++callStackLocation) {
-            next = new FunctionCallProfile(*callStackLocation);
-            callTreeInsertionPoint->addChild(next);
-            callTreeInsertionPoint = next;
-        }
-    } else    // We are calling a function that is already in the call tree.
-        foundNameInTree->willExecute();
+    m_currentProfile->didExecute(callStackNames);
 }
 
@@ -172 +153 @@
 }
 
-void Profiler::printDataInspectorStyle() const
+void Profiler::printDataInspectorStyle(unsigned whichProfile) const
 {
-    printf("Profiler Call graph:\n");
-    m_callTree->printDataInspectorStyle(0);
+    m_allProfiles[whichProfile]->printDataInspectorStyle();
 }
 
-typedef pair<UString::Rep*, unsigned> NameCountPair;
-
-static inline bool functionNameCountPairComparator(const NameCountPair a, const NameCountPair b)
+void Profiler::printDataSampleStyle(unsigned whichProfile) const
 {
-    return a.second > b.second;
-}
-
-void Profiler::printDataSampleStyle() const
-{
-    typedef Vector<NameCountPair> NameCountPairVector;
-
-    FunctionCallHashCount countedFunctions;
-    printf("Call graph:\n");
-    m_callTree->printDataSampleStyle(0, countedFunctions);
-
-    printf("\nTotal number in stack:\n");
-    NameCountPairVector sortedFunctions(countedFunctions.size());
-    copyToVector(countedFunctions, sortedFunctions);
-
-    std::sort(sortedFunctions.begin(), sortedFunctions.end(), functionNameCountPairComparator);
-    for (NameCountPairVector::iterator it = sortedFunctions.begin(); it != sortedFunctions.end(); ++it)
-        printf("        %-12d%s\n", (*it).second, UString((*it).first).UTF8String().c_str());
-
-    printf("\nSort by top of stack, same collapsed (when >= 5):\n");
+    m_allProfiles[whichProfile]->printDataSampleStyle();
 }