Changeset 3306 in webkit for trunk/JavaScriptCore/kjs/internal.cpp

Timestamp:

Jan 12, 2003, 10:43:08 AM (22 years ago)

Author:

darin

Message:

Reviewed by John.

• changes inspired by things I noticed reviewing diffs vs. KDE when preparing the tarball

• kjs/function.cpp: (GlobalFuncImp::call): Use strtol when strtoll is not available. Do #ifndef NDEBUG, not #if !NDEBUG.
• kjs/function.h: Do #ifndef NDEBUG, not #if !NDEBUG.
• kjs/internal.cpp: (InterpreterImp::initGlobalObject): Do #ifndef NDEBUG, not #if !NDEBUG. (KJS::printInfo): Remove case for ListType and remove default case that just ends up suppressing the "missing case" warning and does no good.
• kjs/interpreter.cpp: (Interpreter::evaluate): Do #ifndef NDEBUG, not #if !NDEBUG.
• kjs/nodes.cpp: (Node::finalCheck): Fix accidentally-deleted code in an ifdef we never compile. (FunctionCallNode::evaluate): Remove bogus XXX comment. Maciej put this comment in, and together we determined it's not needed. (TypeOfNode::evaluate): Ditto.
• kjs/object.cpp: Remove assert that refers to ListType.
• kjs/value.h: Remove ListType.

File:

• trunk/JavaScriptCore/kjs/internal.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/internal.cpp

@@ -649 +649 @@
   global.put(globExec,"escape",     Object(new GlobalFuncImp(globExec,funcProto,GlobalFuncImp::Escape,     1)), DontEnum);
   global.put(globExec,"unescape",   Object(new GlobalFuncImp(globExec,funcProto,GlobalFuncImp::UnEscape,   1)), DontEnum);
-#if !NDEBUG
+#ifndef NDEBUG
   global.put(globExec,"kjsprint",   Object(new GlobalFuncImp(globExec,funcProto,GlobalFuncImp::KJSPrint,   1)), DontEnum);
 #endif
@@ -897 +897 @@
         name = "(unknown class)";
       break;
-    case ListType:
-      name = "List";
-      break;
-    default:
-      break;
     }
     UString vString = v.toString(exec);