Changeset 3306 in webkit for trunk/JavaScriptCore/kjs/nodes.cpp

Timestamp:

Jan 12, 2003, 10:43:08 AM (22 years ago)

Author:

darin

Message:

Reviewed by John.

• changes inspired by things I noticed reviewing diffs vs. KDE when preparing the tarball

• kjs/function.cpp: (GlobalFuncImp::call): Use strtol when strtoll is not available. Do #ifndef NDEBUG, not #if !NDEBUG.
• kjs/function.h: Do #ifndef NDEBUG, not #if !NDEBUG.
• kjs/internal.cpp: (InterpreterImp::initGlobalObject): Do #ifndef NDEBUG, not #if !NDEBUG. (KJS::printInfo): Remove case for ListType and remove default case that just ends up suppressing the "missing case" warning and does no good.
• kjs/interpreter.cpp: (Interpreter::evaluate): Do #ifndef NDEBUG, not #if !NDEBUG.
• kjs/nodes.cpp: (Node::finalCheck): Fix accidentally-deleted code in an ifdef we never compile. (FunctionCallNode::evaluate): Remove bogus XXX comment. Maciej put this comment in, and together we determined it's not needed. (TypeOfNode::evaluate): Ditto.
• kjs/object.cpp: Remove assert that refers to ListType.
• kjs/value.h: Remove ListType.

File:

• trunk/JavaScriptCore/kjs/nodes.cpp (modified) (3 diffs)

trunk/JavaScriptCore/kjs/nodes.cpp

@@ -116 +116 @@
 {
   fprintf( stderr, "Node::finalCheck(): list count       : %d\n", (int)s_nodes.size() );
+  std::list<Node *>::iterator it = s_nodes->begin();
+  for ( uint i = 0; it != s_nodes->end() ; ++it, ++i )
     fprintf( stderr, "[%d] Still having node %p (%s) (refcount %d)\n", i, (void*)*it, typeid( **it ).name(), (*it)->refcount );
   delete s_nodes;
@@ -728 +730 @@
 
   Value thisVal;
-  // XXX - should check for constant reference
   if (ref.isMutable())
     thisVal = ref.getBase(exec);
@@ -862 +863 @@
   Reference ref = expr->evaluateReference(exec);
   KJS_CHECKEXCEPTIONVALUE
-  // XXX - Really should check if this is a constant reference
   if (ref.isMutable()) {
     Value b = ref.getBase(exec);