Changeset 33382 in webkit for trunk/JavaScriptCore/profiler/FunctionCallProfile.h

Timestamp:

May 13, 2008, 12:35:31 PM (17 years ago)

Author:

[email protected]

Message:

2008-05-13 Kevin McCullough <​[email protected]>

Reviewed by Sam.

<rdar://problem/5770054> JavaScript profiler (10928)

• Made some functions static (as per Adam) and changed from using raw pointers to RefPtr for making these JavaScript Objects.

• profiler/FunctionCallProfile.cpp: (KJS::FunctionCallProfile::addChild): (KJS::FunctionCallProfile::findChild):
• profiler/FunctionCallProfile.h: (KJS::FunctionCallProfile::create):
• profiler/Profile.cpp: (KJS::Profile::Profile): (KJS::Profile::willExecute): (KJS::Profile::didExecute): (KJS::functionNameCountPairComparator):
• profiler/Profile.h: (KJS::Profile::create): (KJS::Profile::title): (KJS::Profile::callTree):
• profiler/Profiler.cpp: (KJS::Profiler::startProfiling):
• profiler/Profiler.h: (KJS::Profiler::allProfiles): (KJS::Profiler::clearProfiles):

File:

• trunk/JavaScriptCore/profiler/FunctionCallProfile.h (modified) (5 diffs)

trunk/JavaScriptCore/profiler/FunctionCallProfile.h

@@ -32 +32 @@
 #include <kjs/ustring.h>
 #include <wtf/Deque.h>
+#include <wtf/RefCounted.h>
+#include <wtf/RefPtr.h>
 #include <wtf/StrHash.h>
 
@@ -38 +40 @@
     class FunctionCallProfile;
 
-    typedef Deque<FunctionCallProfile*>::const_iterator StackIterator;
+    typedef Deque<RefPtr<FunctionCallProfile> >::const_iterator StackIterator;
     typedef HashCountedSet<UString::Rep*> FunctionCallHashCount;
 
-    class FunctionCallProfile {
+    class FunctionCallProfile : public RefCounted<FunctionCallProfile> {
     public:
-        FunctionCallProfile(const UString& name);        
-        ~FunctionCallProfile();
+        static PassRefPtr<FunctionCallProfile> create(const UString& name) { return adoptRef(new FunctionCallProfile(name)); }
 
         void willExecute();
         void didExecute(Vector<UString> stackNames, unsigned int stackIndex);
 
-        void addChild(FunctionCallProfile* child);
+        void addChild(RefPtr<FunctionCallProfile>& child);
         FunctionCallProfile* findChild(const UString& name);
 
@@ -57 +58 @@
         double milliSecs() const { return m_timeSum; }
         unsigned numberOfCalls() const { return m_numberOfCalls; }
+        const Deque<RefPtr<FunctionCallProfile> >& children() { return m_children; }
 
         void printDataInspectorStyle(int indentLevel) const;
@@ -62 +64 @@
 
     private:
+        FunctionCallProfile(const UString& name);
+
         void endAndRecordCall();
     
@@ -69 +73 @@
         unsigned m_numberOfCalls;
 
-        Deque<FunctionCallProfile*> m_children;
+        Deque<RefPtr<FunctionCallProfile> > m_children;
     };