Changeset 33382 in webkit for trunk/JavaScriptCore/profiler/Profile.cpp

Timestamp:

May 13, 2008, 12:35:31 PM (17 years ago)

Author:

[email protected]

Message:

2008-05-13 Kevin McCullough <​[email protected]>

Reviewed by Sam.

<rdar://problem/5770054> JavaScript profiler (10928)

• Made some functions static (as per Adam) and changed from using raw pointers to RefPtr for making these JavaScript Objects.

• profiler/FunctionCallProfile.cpp: (KJS::FunctionCallProfile::addChild): (KJS::FunctionCallProfile::findChild):
• profiler/FunctionCallProfile.h: (KJS::FunctionCallProfile::create):
• profiler/Profile.cpp: (KJS::Profile::Profile): (KJS::Profile::willExecute): (KJS::Profile::didExecute): (KJS::functionNameCountPairComparator):
• profiler/Profile.h: (KJS::Profile::create): (KJS::Profile::title): (KJS::Profile::callTree):
• profiler/Profiler.cpp: (KJS::Profiler::startProfiling):
• profiler/Profiler.h: (KJS::Profiler::allProfiles): (KJS::Profiler::clearProfiles):

File:

• trunk/JavaScriptCore/profiler/Profile.cpp (modified) (4 diffs)

trunk/JavaScriptCore/profiler/Profile.cpp

@@ -43 +43 @@
     // FIXME: When multi-threading is supported this will be a vector and calls
     // into the profiler will need to know which thread it is executing on.
-    m_callTree.set(new FunctionCallProfile("Thread_1"));
+    m_callTree = FunctionCallProfile::create("Thread_1");
 }
 
 void Profile::willExecute(const Vector<UString>& callStackNames)
 {
-    FunctionCallProfile* callTreeInsertionPoint = 0;
-    FunctionCallProfile* foundNameInTree = m_callTree.get();
+    RefPtr<FunctionCallProfile> callTreeInsertionPoint;
+    RefPtr<FunctionCallProfile> foundNameInTree = m_callTree;
     NameIterator callStackLocation = callStackNames.begin();
 
@@ -60 +60 @@
     if (!foundNameInTree) {   // Insert remains of the stack into the call tree.
         --callStackLocation;
-        for (FunctionCallProfile* next; callStackLocation != callStackNames.end(); ++callStackLocation) {
-            next = new FunctionCallProfile(*callStackLocation);
+        for (RefPtr<FunctionCallProfile> next; callStackLocation != callStackNames.end(); ++callStackLocation) {
+            next = FunctionCallProfile::create(*callStackLocation);
             callTreeInsertionPoint->addChild(next);
             callTreeInsertionPoint = next;
@@ -69 +69 @@
 }
 
-void Profile::didExecute(Vector<UString> stackNames)
+void Profile::didExecute(const Vector<UString>& stackNames)
 {
     m_callTree->didExecute(stackNames, 0);    
@@ -82 +82 @@
 typedef pair<UString::Rep*, unsigned> NameCountPair;
 
-static inline bool functionNameCountPairComparator(const NameCountPair a, const NameCountPair b)
+static inline bool functionNameCountPairComparator(const NameCountPair& a, const NameCountPair& b)
 {
     return a.second > b.second;