Changeset 33581 in webkit for trunk/JavaScriptCore/profiler/Profiler.cpp

Timestamp:

May 19, 2008, 3:15:30 PM (17 years ago)

Author:

[email protected]

Message:

2008-05-19 Kevin McCullough <​[email protected]>

Reviewed by Tim.

<rdar://problem/5770054> JavaScript profiler (10928)
-In an effort to make the profiler as efficient as possible instead of
prepending to a vector we keep the vector in reverse order and operate
over it backwards.

• profiler/Profile.cpp: (KJS::Profile::willExecute): (KJS::Profile::didExecute):
• profiler/ProfileNode.cpp: (KJS::ProfileNode::didExecute): (KJS::ProfileNode::endAndRecordCall):
• profiler/ProfileNode.h:
• profiler/Profiler.cpp: (KJS::getStackNames):

File:

• trunk/JavaScriptCore/profiler/Profiler.cpp (modified) (3 diffs)

trunk/JavaScriptCore/profiler/Profiler.cpp

@@ -122 +122 @@
     for (ExecState* currentState = exec; currentState; currentState = currentState->callingExecState()) {
         if (FunctionImp* functionImp = currentState->function())
-            names.prepend(getFunctionName(functionImp));
+            names.append(getFunctionName(functionImp));
         else if (ScopeNode* scopeNode = currentState->scopeNode())
-            names.prepend(Script + scopeNode->sourceURL() + ": " + UString::from(scopeNode->lineNo() + 1));   // FIXME: Why is the line number always off by one?
+            names.append(Script + scopeNode->sourceURL() + ": " + UString::from(scopeNode->lineNo() + 1));   // FIXME: Why is the line number always off by one?
     }
 }
@@ -130 +130 @@
 void getStackNames(Vector<UString>& names, ExecState* exec, JSObject* calledFunction)
 {
-    getStackNames(names, exec);
     if (calledFunction->inherits(&FunctionImp::info))
         names.append(getFunctionName(static_cast<FunctionImp*>(calledFunction)));
     else if (calledFunction->inherits(&InternalFunctionImp::info))
         names.append(static_cast<InternalFunctionImp*>(calledFunction)->functionName().ustring());
+    getStackNames(names, exec);
 }
 
@@ -140 +140 @@
 void getStackNames(Vector<UString>& names, ExecState* exec, const UString& sourceURL, int startingLineNumber)
 {
+    names.append(Script + sourceURL + ": " + UString::from(startingLineNumber + 1));
     getStackNames(names, exec);
-    names.append(Script + sourceURL + ": " + UString::from(startingLineNumber + 1));
 }