Changeset 33593 in webkit for trunk/JavaScriptCore/profiler/ProfileNode.cpp

Timestamp:

May 19, 2008, 7:03:14 PM (17 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

2008-05-19 Kevin McCullough <​[email protected]>

Reviewed by Adam.

<rdar://problem/5770054> JavaScript profiler (10928)

• Pass the exec state to profiler when calling startProfiling so that if profiling is started within an execution context that location is recorded correctly.

• JavaScriptCore.exp:
• profiler/ProfileNode.cpp: (KJS::ProfileNode::printDataInspectorStyle): Dump more info for debugging purposes.
• profiler/Profiler.cpp: (KJS::Profiler::startProfiling):
• profiler/Profiler.h:

WebCore:

2008-05-19 Kevin McCullough <​[email protected]>

Reviewed by Adam.

<rdar://problem/5770054> JavaScript profiler (10928)

• Send the executing context to the profiler so it can attribute time correctly to parent functions when calling profile() and profileEnd() while nested.

• page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd):
• page/Console.h:

File:

• trunk/JavaScriptCore/profiler/ProfileNode.cpp (modified) (1 diff)

trunk/JavaScriptCore/profiler/ProfileNode.cpp

@@ -202 +202 @@
 {
     // Print function names
-    if (indentLevel) {
-        for (int i = 0; i < indentLevel; ++i)
-            printf("  ");
-
-        printf("%d SelfTime %.3fms %.3f%% TotalTime %.3fms%.3f%% FunctionName %s\n", m_numberOfCalls, m_selfTime, selfPercent(), m_totalTime, totalPercent(), m_functionName.UTF8String().c_str());
-    } else
-        printf("%s\n", m_functionName.UTF8String().c_str());
+    for (int i = 0; i < indentLevel; ++i)
+        printf("  ");
+
+    printf("%d SelfTime %.3fms/%.3f%% TotalTime %.3fms/%.3f%% FunctionName %s\n", m_numberOfCalls, m_selfTime, selfPercent(), m_totalTime, totalPercent(), m_functionName.UTF8String().c_str());
 
     ++indentLevel;