Changeset 33972 in webkit for trunk/JavaScriptCore/kjs/function.h

Timestamp:

May 21, 2008, 12:15:01 PM (17 years ago)

Author:

Darin Adler

Message:

JavaScriptCore:

2008-05-21 Darin Adler <Darin Adler>

Reviewed by Anders.

• fix <rdar://problem/5952721> bug in JavaScript arguments object property lookup

Test: fast/js/arguments-bad-index.html

• kjs/function.cpp: (KJS::IndexToNameMap::IndexToNameMap): Use unsigned instead of int. (KJS::IndexToNameMap::isMapped): Use unsigned instead of int, and also use the strict version of the numeric conversion function, since we don't want to allow trailing junk. (KJS::IndexToNameMap::unMap): Ditto. (KJS::IndexToNameMap::operator[]): Ditto.
• kjs/function.h: Changed IndexToNameMap::size type from int to unsigned.

LayoutTests:

2008-05-21 Darin Adler <Darin Adler>

Reviewed by Anders.

• test for <rdar://problem/5952721> bug in JavaScript arguments object property lookup

• fast/js/arguments-bad-index-expected.txt: Added.
• fast/js/arguments-bad-index.html: Added.
• fast/js/resources/arguments-bad-index.js: Added.

File:

• trunk/JavaScriptCore/kjs/function.h (modified) (1 diff)

trunk/JavaScriptCore/kjs/function.h

@@ -94 +94 @@
   class IndexToNameMap {
   public:
-    IndexToNameMap(FunctionImp* func, const List& args);
+    IndexToNameMap(FunctionImp*, const List& args);
     ~IndexToNameMap();
     
-    Identifier& operator[](int index);
-    Identifier& operator[](const Identifier &indexIdentifier);
+    Identifier& operator[](const Identifier& index);
     bool isMapped(const Identifier& index) const;
     void unMap(const Identifier& index);
     
   private:
-    IndexToNameMap(); // prevent construction w/o parameters
-    int size;
+    unsigned size;
     Identifier* _map;
   };