Changeset 34047 in webkit for trunk/JavaScriptCore/profiler/Profiler.cpp

Timestamp:

May 22, 2008, 9:32:33 PM (17 years ago)

Author:

Adam Roben

Message:

Fix a profiler assertion when calling a NodeList as a function

JavaScriptCore:

Fix a profiler assertion when calling a NodeList as a function

Reviewed by Kevin McCullough.

• profiler/Profiler.cpp: (KJS::createCallIdentifier): Don't assert when a non-function object is called as a function. Instead, build up a CallIdentifier using the object's class name.

WebCore:

Add a test for calling a NodeList as a function while profiling

Reviewed by Kevin McCullough.

• manual-tests/inspector/profiler-test-call-nodelist-as-function.html: Added.

File:

• trunk/JavaScriptCore/profiler/Profiler.cpp (modified) (1 diff)

trunk/JavaScriptCore/profiler/Profiler.cpp

@@ -161 +161 @@
         return CallIdentifier(static_cast<InternalFunctionImp*>(calledFunction)->functionName().ustring(), "", 0);
 
-    ASSERT_NOT_REACHED();
-    return CallIdentifier("", 0, 0);
+    UString name = "(";
+    name += calledFunction->classInfo()->className;
+    name += " object)";
+    return CallIdentifier(name, 0, 0);
 }