Changeset 34051 in webkit for trunk/JavaScriptCore

Timestamp:

May 22, 2008, 10:15:28 PM (17 years ago)

Author:

[email protected]

Message:

Adds Focus, Exclude and Restore buttons to the Profile view
Status bar. Also adds a Record button to create new profiles.

<rdar://problem/5950867> JSProfiler: Allow the profiler to "Focus" a profile node.
<rdar://problem/5951529> JSProfiler: Allow the profiler to "Exclude" a profile node.

Reviewed by Adam Roben.

• English.lproj/localizedStrings.js: Added new strings.
• page/JavaScriptProfile.cpp:

(WebCore::restoreAll): Call Profile::restoreAll.
(WebCore::ProfileClass): Added restoreAll to the static functions.

• page/inspector/Images/excludeButtons.png: Added.
• page/inspector/Images/focusButtons.png: Added.
• page/inspector/Images/recordButtons.png: Added.
• page/inspector/Images/reloadButtons.png: Added.
• page/inspector/ProfileView.js:

(WebInspector.ProfileView): Create the buttons elements.
(WebInspector.ProfileView.prototype.get statusBarItems): Return the three
status bar buttons.
(WebInspector.ProfileView.prototype.refresh): Only create ProfileDataGridNodes
for ProfileNodes that are visible.
(WebInspector.ProfileView.prototype.refreshShowAsPercents): Just call
refresh on the children, now that they have access to the ProfileView's properties.
(WebInspector.ProfileView.prototype._focusClicked): Call focus
on the profile, refresh the ProfileView and show the reset button.
(WebInspector.ProfileView.prototype._excludeClicked): Call exclude
on the profile, refresh the ProfileView and show the reset button.
(WebInspector.ProfileView.prototype._resetClicked): Call restoreAll
on the profile, refresh the ProfileView and hide the reset button.
(WebInspector.ProfileView.prototype._dataGridNodeSelected): Enable the
focus and exclude buttons.
(WebInspector.ProfileView.prototype._dataGridNodeDeselected): Disable the
focus and exclude buttons.
(WebInspector.ProfileDataGridNode): Take a ProfileView, and remove the
showPercentAs* arguments.

• page/inspector/ProfilesPanel.js: Add a record status bar button and

th ability to have per-view status bar buttons.

• page/inspector/inspector.css: New styles.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• JavaScriptCore.exp (modified) (1 diff)
• profiler/Profile.h (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-05-22  Timothy Hatcher  <[email protected]>
+
+        Added Profile::restoreAll and added ProfileNode::restoreAll
+        to the export file.
+
+        Reviewed by Adam Roben.
+
+        * JavaScriptCore.exp:
+        * profiler/Profile.h:
+
 2008-05-22  Alp Toker  <[email protected]>
 

trunk/JavaScriptCore/JavaScriptCore.exp

@@ -92 +92 @@
 __ZN3KJS11JSImmediate8toStringEPKNS_7JSValueE
 __ZN3KJS11ProfileNode5focusERKNS_14CallIdentifierEb
+__ZN3KJS11ProfileNode10restoreAllEv
 __ZN3KJS11ProfileNode7excludeERKNS_14CallIdentifierE
 __ZN3KJS11ProfileNode18sortCallsAscendingEv

trunk/JavaScriptCore/profiler/Profile.h

@@ -62 +62 @@
         void focus(const ProfileNode* profileNode) { if (!profileNode) return; m_headNode->focus(profileNode->callIdentifier()); }
         void exclude(const ProfileNode* profileNode) { if (!profileNode) return; m_headNode->exclude(profileNode->callIdentifier()); }
+        void restoreAll() { m_headNode->restoreAll(); }
 
 #ifndef NDEBUG