Changeset 34054 in webkit for trunk/JavaScriptCore

Timestamp:

May 22, 2008, 11:09:33 PM (17 years ago)

Author:

Adam Roben

Message:

Show "(Function object)" instead of "(JSInpectorCallbackWrapper object)" in profiles

Reviewed by Kevin McCullough.

• profiler/Profiler.cpp: (KJS::createCallIdentifier): Use JSObject::className instead of getting the class name from the ClassInfo directly. JSObject subclasses can override className to provide a custom class name, and it seems like we should honor that.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• profiler/Profiler.cpp (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-05-22  Adam Roben  <[email protected]>
+
+        Show "(Function object)" instead of "(JSInpectorCallbackWrapper
+        object)" in profiles
+
+        Reviewed by Kevin McCullough.
+
+        * profiler/Profiler.cpp:
+        (KJS::createCallIdentifier): Use JSObject::className instead of
+        getting the class name from the ClassInfo directly. JSObject
+        subclasses can override className to provide a custom class name, and
+        it seems like we should honor that.
+
 2008-05-22  Timothy Hatcher  <[email protected]>
 

trunk/JavaScriptCore/profiler/Profiler.cpp

@@ -161 +161 @@
         return CallIdentifier(static_cast<InternalFunctionImp*>(calledFunction)->functionName().ustring(), "", 0);
 
-    UString name = "(";
-    name += calledFunction->classInfo()->className;
-    name += " object)";
+    UString name = "(" + calledFunction->className() + " object)";
     return CallIdentifier(name, 0, 0);
 }