Changeset 34060 in webkit for trunk/JavaScriptCore/profiler/ProfileNode.cpp

Timestamp:

May 22, 2008, 11:57:44 PM (17 years ago)

Author:

[email protected]

Message:

2008-05-22 Kevin McCullough <​[email protected]>

Reviewed by Adam.

Fix a bug in the profiler where time in the current function is given to
(idle).

• profiler/Profile.cpp: (KJS::Profile::didExecute): Set the start time and then call didExecute to calculate the time spent in this function.
• profiler/ProfileNode.cpp: Remove confusing calculations that are no longer necessary. (KJS::ProfileNode::insertNode):
• profiler/ProfileNode.h: Expose access to the start time to allow the simpler time calculations above. (KJS::ProfileNode::startTime): (KJS::ProfileNode::setStartTime):

File:

• trunk/JavaScriptCore/profiler/ProfileNode.cpp (modified) (1 diff)

trunk/JavaScriptCore/profiler/ProfileNode.cpp

@@ -105 +105 @@
     RefPtr<ProfileNode> node = prpNode;
 
-    double sumOfChildrensTime = 0.0;
-    for (unsigned i = 0; i < m_children.size(); ++i) {
-        sumOfChildrensTime += m_children[i]->totalTime();
+    for (unsigned i = 0; i < m_children.size(); ++i)
         node->addChild(m_children[i].release());
-    }
 
     m_children.clear();
-
-    node->didExecute();
-    node->setTotalTime(sumOfChildrensTime);
-    node->setSelfTime(0.0);
     m_children.append(node.release());
 }