Changeset 34075 in webkit for trunk/JavaScriptCore/VM/ExceptionHelpers.cpp

Timestamp:

May 23, 2008, 7:23:23 AM (17 years ago)

Author:

[email protected]

Message:

SQUIRRELFISH: JavaScript error messages are missing informative text

Reviewed by Anders

Partial fix.
Tidy up error messages, makes a couple of them provide slightly more info.
Inexplicably leads to a 1% SunSpider Progression.

File:

• trunk/JavaScriptCore/VM/ExceptionHelpers.cpp (modified) (4 diffs)

trunk/JavaScriptCore/VM/ExceptionHelpers.cpp

@@ -48 +48 @@
 JSValue* createError(ExecState* exec, ErrorType e, const char* msg)
 {
-    return Error::create(exec, e, msg, -1, -1, 0); // lineNo(), currentSourceId(exec), currentSourceURL(exec)
+    return Error::create(exec, e, msg, -1, -1, 0);
 }
 
@@ -55 +55 @@
     UString message = msg;
     substitute(message, label.ustring());
-    return Error::create(exec, e, message, -1, -1, 0); // lineNo(), currentSourceId(exec), currentSourceURL(exec)
+    return Error::create(exec, e, message, -1, -1, 0);
 }
 
@@ -64 +64 @@
     if (expr)
         substitute(message, expr->toString());
-    else
-        substitute(message, "<<no string for expression>>");
-    return Error::create(exec, e, message, -1, -1, 0); //, lineNo(), currentSourceId(exec), currentSourceURL(exec));
+    return Error::create(exec, e, message, -1, -1, 0);
+}
+
+JSValue* createError(ExecState* exec, ErrorType e, const char* msg, JSValue* v)
+{
+    UString message = msg;
+    substitute(message, v->toString(exec));
+    return Error::create(exec, e, message, -1, -1, 0);
 }
 
@@ -78 +83 @@
     return createError(exec, ReferenceError, "Can't find variable: %s", ident);
 }
-
-JSValue* createNotAnObjectError(ExecState* exec, JSValue* value, Node* expr)
+    
+JSValue* createInvalidParamError(ExecState* exec, const char* op, JSValue* v)
 {
-    return createError(exec, TypeError, "Value %s (result of expression %s) is not an object.", value, expr);
+    UString message = "'%s' is not a valid argument for '%s'";
+    substitute(message,  v->toString(exec));
+    substitute(message, op);
+    return Error::create(exec, TypeError, message, -1, -1, 0);
 }
 
 JSValue* createNotAConstructorError(ExecState* exec, JSValue* value, Node* expr)
 {
-    if (!value->isObject())
-        return createNotAnObjectError(exec, value, expr);
-    return createError(exec, TypeError, "Value %s (result of expression %s) is not a constructor. Cannot be used with new.", value, expr);
+    if (expr)
+        return createError(exec, TypeError, "Value %s (result of expression %s) is not a constructor. Cannot be used with new.", value, expr);
+    return createError(exec, TypeError, "Value %s is not a constructor. Cannot be used with new.", value);
 }
 
 JSValue* createNotAFunctionError(ExecState* exec, JSValue* value, Node* expr)
 {
-    if (!value->isObject())
-        return createNotAnObjectError(exec, value, expr);
-    return createError(exec, TypeError, "Value %s (result of expression %s) does not allow function calls.", value, expr);
+    if (expr)
+        return createError(exec, TypeError, "Value %s (result of expression %s) does not allow function calls.", value, expr);
+    return createError(exec, TypeError, "Value %s does not allow function calls.", value);
 }