Changeset 34118 in webkit for trunk/JavaScriptCore/kjs/array_instance.cpp

Timestamp:

May 25, 2008, 12:15:42 AM (17 years ago)

Author:

[email protected]

Message:

Reviewed by Darin.

Changed regular expression matching result array to be lazily filled, because many callers
only care about it being non-null.

2% improvement on Acid3 test 26.

• kjs/array_instance.cpp: Added a void* member to ArrayStorage for ArrayInstance subclasses to use.
• kjs/array_instance.h: (KJS::ArrayInstance::lazyCreationData): (KJS::ArrayInstance::setLazyCreationData): Added methods to access it from subclasses.

• kjs/regexp_object.cpp: (KJS::RegExpMatchesArray::RegExpMatchesArray): (KJS::RegExpMatchesArray::getOwnPropertySlot): (KJS::RegExpMatchesArray::put): (KJS::RegExpMatchesArray::deleteProperty): (KJS::RegExpMatchesArray::getPropertyNames): (KJS::RegExpMatchesArray::fillArrayInstanceIfNeeded): (KJS::RegExpMatchesArray::~RegExpMatchesArray): (KJS::RegExpObjectImp::arrayOfMatches): RegExpMatchesArray is a subclass of ArrayInstance that isn't filled until accessed for the first time.

File:

• trunk/JavaScriptCore/kjs/array_instance.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/array_instance.cpp

@@ -37 +37 @@
     unsigned m_numValuesInVector;
     SparseArrayValueMap* m_sparseValueMap;
+    void* lazyCreationData; // An ArrayInstance subclass can use this to fill the vector lazily.
     JSValue* m_vector[1];
 };
@@ -683 +684 @@
 }
 
-}
+void* ArrayInstance::lazyCreationData()
+{
+    return m_storage->lazyCreationData;
+}
+
+void ArrayInstance::setLazyCreationData(void* d)
+{
+    m_storage->lazyCreationData = d;
+}
+
+}