Changeset 34149 in webkit for trunk/JavaScriptCore/VM/Machine.cpp

Timestamp:

May 27, 2008, 7:43:36 AM (17 years ago)

Author:

Darin Adler

Message:

2008-05-27 Darin Adler <Darin Adler>

Reviewed by Tim Hatcher.

• ​https://bugs.webkit.org/show_bug.cgi?id=19180 speed up SunSpider by optimizing immediate number cases

Add immediate number cases for the &, |, and ^{operators.
Makes standalone SunSpider 1.010x faster.}

• VM/Machine.cpp: (KJS::Machine::privateExecute): Add areBothImmediateNumbers special cases for the &, |, and ^operators.

• kjs/JSImmediate.h: (KJS::JSImmediate::xorImmediateNumbers): Added. (KJS::JSImmediate::orImmediateNumbers): Added.

File:

• trunk/JavaScriptCore/VM/Machine.cpp (modified) (3 diffs)

trunk/JavaScriptCore/VM/Machine.cpp

@@ -1309 +1309 @@
         int src1 = (++vPC)->u.operand;
         int src2 = (++vPC)->u.operand;
-        JSValue* result = jsNumber((r[src1].u.jsValue->toInt32(exec)) & (r[src2].u.jsValue->toInt32(exec)));
-        VM_CHECK_EXCEPTION();
+        JSValue* v1 = r[src1].u.jsValue;
+        JSValue* v2 = r[src2].u.jsValue;
+        JSValue* result;
+        if (JSImmediate::areBothImmediateNumbers(v1, v2))
+            result = JSImmediate::andImmediateNumbers(v1, v2);
+        else {
+            result = jsNumber(v1->toInt32(exec) & v2->toInt32(exec));
+            VM_CHECK_EXCEPTION();
+        }
         r[dst].u.jsValue = result;
         
@@ -1326 +1333 @@
         int src1 = (++vPC)->u.operand;
         int src2 = (++vPC)->u.operand;
-        JSValue* result = jsNumber((r[src1].u.jsValue->toInt32(exec)) ^ (r[src2].u.jsValue->toInt32(exec)));
-        VM_CHECK_EXCEPTION();
+        JSValue* v1 = r[src1].u.jsValue;
+        JSValue* v2 = r[src2].u.jsValue;
+        JSValue* result;
+        if (JSImmediate::areBothImmediateNumbers(v1, v2))
+            result = JSImmediate::xorImmediateNumbers(v1, v2);
+        else {
+            result = jsNumber(v1->toInt32(exec) ^ v2->toInt32(exec));
+            VM_CHECK_EXCEPTION();
+        }
         r[dst].u.jsValue = result;
         
@@ -1343 +1357 @@
         int src1 = (++vPC)->u.operand;
         int src2 = (++vPC)->u.operand;
-        JSValue* result = jsNumber((r[src1].u.jsValue->toInt32(exec)) | (r[src2].u.jsValue->toInt32(exec)));
-        VM_CHECK_EXCEPTION();
+        JSValue* v1 = r[src1].u.jsValue;
+        JSValue* v2 = r[src2].u.jsValue;
+        JSValue* result;
+        if (JSImmediate::areBothImmediateNumbers(v1, v2))
+            result = JSImmediate::orImmediateNumbers(v1, v2);
+        else {
+            result = jsNumber(v1->toInt32(exec) | v2->toInt32(exec));
+            VM_CHECK_EXCEPTION();
+        }
         r[dst].u.jsValue = result;