Changeset 34372 in webkit for trunk/JavaScriptCore/VM/CodeGenerator.cpp

Timestamp:

Jun 4, 2008, 10:36:55 PM (17 years ago)

Author:

[email protected]

Message:

2008-06-04 Sam Weinig <​[email protected]>

Reviewed by Maciej Stachowiak.

Big cleanup of formatting and whitespace.

File:

• trunk/JavaScriptCore/VM/CodeGenerator.cpp (modified) (26 diffs)

trunk/JavaScriptCore/VM/CodeGenerator.cpp

@@ -40 +40 @@
 /*
     The layout of a register frame looks like this:
-    
-    For 
-    
+
+    For
+
     function f(x, y) {
         var v1;
@@ -49 +49 @@
         return (x) * (y);
     }
-    
+
     assuming (x) and (y) generated temporaries t1 and t2, you would have
 
@@ -58 +58 @@
     ------------------------------------
     | params->|<-locals      | temps->
-    
+
     Because temporary registers are allocated in a stack-like fashion, we
     can reclaim them with a simple popping algorithm. The same goes for labels.
     (We never reclaim parameter or local registers, because parameters and
     locals are DontDelete.)
-    
+
     The register layout before a function call looks like this:
-    
+
     For
-    
+
     function f(x, y)
     {
     }
-    
+
     f(1);
-    
+
     >                        <------------------------------
     <                        >  reserved: call frame  |  1 | <-- value held
@@ -79 +79 @@
     <                        > +0 | +1 | +2 | +3 | +4 | +5 | <-- register index
     >                        <------------------------------
-    | params->|<-locals      | temps->    
-    
+    | params->|<-locals      | temps->
+
     The call instruction fills in the "call frame" registers. It also pads
     missing arguments at the end of the call:
-    
+
     >                        <-----------------------------------
     <                        >  reserved: call frame  |  1 |  ? | <-- value held ("?" stands for "undefined")
@@ -90 +90 @@
     >                        <-----------------------------------
     | params->|<-locals      | temps->
-    
+
     After filling in missing arguments, the call instruction sets up the new
     stack frame to overlap the end of the old stack frame:
@@ -100 +100 @@
                              |---------------------------------->                        <
                              |                        | params->|<-locals       | temps->
-    
+
     That way, arguments are "copied" into the callee's stack frame for free.
-    
+
     If the caller supplies too many arguments, this trick doesn't work. The
     extra arguments protrude into space reserved for locals and temporaries.
@@ -111 +111 @@
     This copying strategy ensures that all named values will be at the indices
     expected by the callee.
-
 */
 
@@ -133 +132 @@
     if (m_shouldEmitDebugHooks)
         m_codeBlock->needsFullScopeChain = true;
-    
+
     m_scopeNode->emitCode(*this);
 
@@ -196 +195 @@
 
     JSGlobalObject* globalObject = scopeChain.globalObject();
-    
+
     ExecState* exec = globalObject->globalExec();
     
@@ -207 +206 @@
             emitNewFunction(addVar(funcDecl->m_ident, false), funcDecl);
         }
-        
+
         for (size_t i = 0; i < varStack.size(); ++i) {
             if (!globalObject->hasProperty(exec, varStack[i].first))
@@ -245 +244 @@
         FuncDeclNode* funcDecl = functionStack[i].get();
         const Identifier& ident = funcDecl->m_ident;
-        
+
         m_functions.add(ident.ustring().rep());
         emitNewFunction(addVar(ident, false), funcDecl);
@@ -255 +254 @@
         if (ident == m_propertyNames->arguments)
             continue;
-        
+
         RegisterID* r0;
         if (addVar(ident, r0, varStack[i].second & DeclarationStacks::IsConstant))
@@ -306 +305 @@
         result = &(m_locals[localsIndex(m_nextParameter)]);
     }
-    
+
     // To maintain the calling convention, we have to allocate unique space for
     // each parameter, even if the parameter doesn't make it into the symbol table.
@@ -336 +335 @@
     if (m_codeType == EvalCode)
         return 0;
-    
+
     SymbolTableEntry entry = symbolTable().get(ident.ustring().rep());
     ASSERT(!entry.isEmpty());
-    
+
     return &m_locals[localsIndex(entry.getIndex())];
 }
@@ -430 +429 @@
     if (result.second) // new entry
         m_codeBlock->identifiers.append(rep);
-    
+
     return result.first->second;
 }
@@ -439 +438 @@
     if (result.second) // new entry
         m_codeBlock->jsValues.append(v);
-    
+
     return result.first->second;
 }
@@ -752 +751 @@
     for (; iter != end; ++iter, ++depth) {
         JSObject* currentScope = *iter;
-        if (!currentScope->isVariableObject()) 
+        if (!currentScope->isVariableObject())
             break;
         JSVariableObject* currentVariableObject = static_cast<JSVariableObject*>(currentScope);
@@ -798 +797 @@
     return emitGetScopedVar(dst, depth, index);
 }
-    
+
 RegisterID* CodeGenerator::emitGetScopedVar(RegisterID* dst, size_t depth, int index)
 {
@@ -807 +806 @@
     return dst;
 }
-    
+
 RegisterID* CodeGenerator::emitPutScopedVar(size_t depth, int index, RegisterID* value)
 {
@@ -824 +823 @@
     return dst;
 }
-    
+
 RegisterID* CodeGenerator::emitResolveWithBase(RegisterID* baseDst, RegisterID* propDst, const Identifier& property)
 {
@@ -965 +964 @@
     RefPtr<RegisterID> refFunc = func;
     RefPtr<RegisterID> refBase = base;
-    
+
     // Reserve space for call frame.
     Vector<RefPtr<RegisterID>, Machine::CallFrameHeaderSize> callFrame;
@@ -1107 +1106 @@
         return 0;
     }
-    
+
     for (int i = m_jumpContextStack.size() - 1; i >= 0; i--) {
         JumpContext* scope = &m_jumpContextStack[i];
@@ -1129 +1128 @@
         return 0;
     }
-    
+
     for (int i = m_jumpContextStack.size() - 1; i >= 0; i--) {
         JumpContext* scope = &m_jumpContextStack[i];
@@ -1152 +1151 @@
 
         if (nNormalScopes) {
-            // We need to remove a number of dynamic scopes to get to the next 
+            // We need to remove a number of dynamic scopes to get to the next
             // finally block
             instructions().append(machine().getOpcode(op_jmp_scopes));
             instructions().append(nNormalScopes);
-            
+
             // If topScope == bottomScope then there isn't actually a finally block
             // left to emit, so make the jmp_scopes jump directly to the target label
@@ -1164 +1163 @@
             }
 
-            // Otherwise we just use jmp_scopes to pop a group of scopes and go 
+            // Otherwise we just use jmp_scopes to pop a group of scopes and go
             // to the next instruction
             RefPtr<LabelID> nextInsn = newLabel();
@@ -1226 +1225 @@
     return targetRegister;
 }
-    
+
 void CodeGenerator::emitThrow(RegisterID* exception)
 {