Changeset 34412 in webkit for trunk/JavaScriptCore/kjs/function.cpp

Timestamp:

Jun 6, 2008, 11:03:24 PM (17 years ago)

Author:

[email protected]

Message:

Reviewed by Darin.

Combine per-thread objects into one, to make it easier to support legacy clients (for
which they shouldn't be really per-thread).

No change on SunSpider total.

• JavaScriptCore.xcodeproj/project.pbxproj: Added JSGlobalData.{h,cpp}

• kjs/JSGlobalData.cpp: Added. (KJS::JSGlobalData::JSGlobalData): (KJS::JSGlobalData::~JSGlobalData): (KJS::JSGlobalData::threadInstance):
• kjs/JSGlobalData.h: Added. This class encapsulates all data that should be per-thread (or shared between legacy clients). It will also keep a Heap pointer, but right now, Heap (Collector) methods are all static.

• kjs/identifier.h: (KJS::Identifier::Identifier): Added a constructor explicitly taking JSGlobalData to access IdentifierTable. Actually, all of them should, but this will be a separate patch.

• kjs/identifier.cpp: (KJS::IdentifierTable::literalTable): (KJS::createIdentifierTable): (KJS::deleteIdentifierTable): (KJS::Identifier::add): (KJS::Identifier::addSlowCase): Combined IdentifierTable and LiteralIdentifierTable into a single class for simplicity.

• kjs/grammar.y: kjsyyparse now takes JSGlobalData, not just a Lexer.

• kjs/nodes.cpp: (KJS::Node::Node): (KJS::EvalFunctionCallNode::emitCode): (KJS::ScopeNode::ScopeNode): Changed to access Lexer and Parser via JSGlobalData::threadInstance(). This is also a temporary measure, they will need to use JSGlobalData explicitly.

• VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator):
• VM/CodeGenerator.h:
• VM/Machine.cpp: (KJS::callEval):
• kjs/CommonIdentifiers.cpp: (KJS::CommonIdentifiers::CommonIdentifiers):
• kjs/CommonIdentifiers.h:
• kjs/DebuggerCallFrame.cpp: (KJS::DebuggerCallFrame::evaluate):
• kjs/ExecState.cpp: (KJS::ExecState::ExecState):
• kjs/ExecState.h: (KJS::ExecState::globalData): (KJS::ExecState::identifierTable): (KJS::ExecState::propertyNames): (KJS::ExecState::emptyList): (KJS::ExecState::lexer): (KJS::ExecState::parser): (KJS::ExecState::arrayTable): (KJS::ExecState::dateTable): (KJS::ExecState::mathTable): (KJS::ExecState::numberTable): (KJS::ExecState::RegExpImpTable): (KJS::ExecState::RegExpObjectImpTable): (KJS::ExecState::stringTable):
• kjs/InitializeThreading.cpp: (KJS::initializeThreadingOnce):
• kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init):
• kjs/JSGlobalObject.h: (KJS::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): (KJS::JSGlobalObject::head): (KJS::JSGlobalObject::globalData):
• kjs/Parser.cpp: (KJS::Parser::parse):
• kjs/Parser.h:
• kjs/function.cpp: (KJS::FunctionImp::getParameterName): (KJS::IndexToNameMap::unMap): (KJS::globalFuncEval):
• kjs/function_object.cpp: (KJS::FunctionObjectImp::construct):
• kjs/interpreter.cpp: (KJS::Interpreter::checkSyntax): (KJS::Interpreter::evaluate):
• kjs/lexer.cpp: (kjsyylex):
• kjs/lexer.h:
• kjs/testkjs.cpp: (prettyPrintScript): Updated for the above changes. Most of threadInstance uses here will need to be replaced with explicitly passed pointers to support legacy JSC clients.

• JavaScriptCore.exp: Removed KJS::parser().

File:

• trunk/JavaScriptCore/kjs/function.cpp (modified) (4 diffs)

trunk/JavaScriptCore/kjs/function.cpp

@@ -166 +166 @@
 
     if (static_cast<size_t>(index) >= body->parameters().size())
-        return CommonIdentifiers::shared()->nullIdentifier;
+        return JSGlobalData::threadInstance().propertyNames->nullIdentifier;
   
     Identifier name = parameters[index];
@@ -174 +174 @@
     for (size_t i = index + 1; i < size; ++i)
         if (parameters[i] == name)
-            return CommonIdentifiers::shared()->nullIdentifier;
+            return JSGlobalData::threadInstance().propertyNames->nullIdentifier;
 
     return name;
@@ -261 +261 @@
   ASSERT(indexIsNumber && indexAsNumber < size);
   
-  _map[indexAsNumber] = CommonIdentifiers::shared()->nullIdentifier;
+  _map[indexAsNumber] = JSGlobalData::threadInstance().propertyNames->nullIdentifier;
 }
 
@@ -575 +575 @@
     UString errMsg;
 
-    RefPtr<EvalNode> evalNode = parser().parse<EvalNode>(exec, UString(), 1, UStringSourceProvider::create(s), &sourceId, &errLine, &errMsg);
+    RefPtr<EvalNode> evalNode = exec->parser()->parse<EvalNode>(exec, UString(), 1, UStringSourceProvider::create(s), &sourceId, &errLine, &errMsg);
     
     if (!evalNode)