Changeset 34510 in webkit for trunk/JavaScriptCore/VM/CodeGenerator.h

Timestamp:

Jun 12, 2008, 2:03:41 AM (17 years ago)

Author:

[email protected]

Message:

2008-06-12 Cameron Zwarich <​[email protected]>

Reviewed by Maciej.

Bug 19510: CodeBlock::needsFullScopeChain not always set for global code
<​https://bugs.webkit.org/show_bug.cgi?id=19510>

This fixes the symptoms by using CodeGenerator::m_codeType to determine
when to use temporaries instead of CodeBlock::needsFullScopeChain, but
it does not fix the problem itself.

JavaScriptCore:

• VM/CodeGenerator.h: (KJS::CodeGenerator::leftHandSideNeedsCopy):

LayoutTests:

• fast/js/codegen-temporaries-multiple-global-blocks-expected.txt: Added.
• fast/js/codegen-temporaries-multiple-global-blocks.html: Added.
• fast/js/resources/codegen-temporaries-multiple-global-blocks-1.js: Added.
• fast/js/resources/codegen-temporaries-multiple-global-blocks-2.js: Added.

File:

• trunk/JavaScriptCore/VM/CodeGenerator.h (modified) (1 diff)

trunk/JavaScriptCore/VM/CodeGenerator.h

@@ -174 +174 @@
         ALWAYS_INLINE bool leftHandSideNeedsCopy(bool rightHasAssignments)
         {
-            return m_codeBlock->needsFullScopeChain || rightHasAssignments;
+            return m_codeType != FunctionCode || m_codeBlock->needsFullScopeChain || rightHasAssignments;
         }