Changeset 34555 in webkit for trunk/JavaScriptCore/VM/CodeGenerator.cpp

Timestamp:

Jun 14, 2008, 10:24:21 PM (17 years ago)

Author:

[email protected]

Message:

2008-06-14 Cameron Zwarich <​[email protected]>

Reviewed by Maciej.

Make code generation not use a temporary for the left-hand side of an
expression if the right-hand side is a local variable.

• VM/CodeGenerator.cpp: (KJS::CodeGenerator::isLocal):
• VM/CodeGenerator.h: (KJS::CodeGenerator::leftHandSideNeedsCopy): (KJS::CodeGenerator::emitNodeForLeftHandSide):
• kjs/nodes.cpp: (KJS::ResolveNode::isPure): (KJS::BracketAccessorNode::emitCode): (KJS::AddNode::emitCode): (KJS::SubNode::emitCode): (KJS::ReadModifyResolveNode::emitCode): (KJS::AssignDotNode::emitCode): (KJS::ReadModifyDotNode::emitCode): (KJS::AssignBracketNode::emitCode): (KJS::ReadModifyBracketNode::emitCode):
• kjs/nodes.h: (KJS::ExpressionNode::): (KJS::BooleanNode::): (KJS::NumberNode::): (KJS::StringNode::):

File:

• trunk/JavaScriptCore/VM/CodeGenerator.cpp (modified) (1 diff)

trunk/JavaScriptCore/VM/CodeGenerator.cpp

@@ -344 +344 @@
 }
 
+bool CodeGenerator::isLocal(const Identifier& ident)
+{
+    if (ident == m_propertyNames->thisIdentifier)
+        return true;
+    
+    return shouldOptimizeLocals() && symbolTable().contains(ident.ustring().rep());
+}
+
 bool CodeGenerator::isLocalConstant(const Identifier& ident)
 {