Changeset 34555 in webkit for trunk/JavaScriptCore/kjs/nodes.h

Timestamp:

Jun 14, 2008, 10:24:21 PM (17 years ago)

Author:

[email protected]

Message:

2008-06-14 Cameron Zwarich <​[email protected]>

Reviewed by Maciej.

Make code generation not use a temporary for the left-hand side of an
expression if the right-hand side is a local variable.

• VM/CodeGenerator.cpp: (KJS::CodeGenerator::isLocal):
• VM/CodeGenerator.h: (KJS::CodeGenerator::leftHandSideNeedsCopy): (KJS::CodeGenerator::emitNodeForLeftHandSide):
• kjs/nodes.cpp: (KJS::ResolveNode::isPure): (KJS::BracketAccessorNode::emitCode): (KJS::AddNode::emitCode): (KJS::SubNode::emitCode): (KJS::ReadModifyResolveNode::emitCode): (KJS::AssignDotNode::emitCode): (KJS::ReadModifyDotNode::emitCode): (KJS::AssignBracketNode::emitCode): (KJS::ReadModifyBracketNode::emitCode):
• kjs/nodes.h: (KJS::ExpressionNode::): (KJS::BooleanNode::): (KJS::NumberNode::): (KJS::StringNode::):

File:

• trunk/JavaScriptCore/kjs/nodes.h (modified) (5 diffs)

trunk/JavaScriptCore/kjs/nodes.h

@@ -209 +209 @@
 
         virtual bool isNumber() const KJS_FAST_CALL { return false; }
-        virtual bool isConstant() const KJS_FAST_CALL { return false; }        
+        virtual bool isPure(CodeGenerator&) const KJS_FAST_CALL { return false; }        
         virtual bool isLocation() const KJS_FAST_CALL { return false; }
         virtual bool isResolveNode() const KJS_FAST_CALL { return false; }
@@ -262 +262 @@
         virtual RegisterID* emitCode(CodeGenerator&, RegisterID* = 0) KJS_FAST_CALL;
 
-        virtual bool isConstant() const KJS_FAST_CALL { return true; }
+        virtual bool isPure(CodeGenerator&) const KJS_FAST_CALL { return true; }
         virtual void streamTo(SourceStream&) const KJS_FAST_CALL;
         virtual Precedence precedence() const { return PrecPrimary; }
@@ -284 +284 @@
 
         virtual bool isNumber() const KJS_FAST_CALL { return true; }
-        virtual bool isConstant() const KJS_FAST_CALL { return true; }
+        virtual bool isPure(CodeGenerator&) const KJS_FAST_CALL { return true; }
         double value() const KJS_FAST_CALL { return m_double; }
         virtual void setValue(double d) KJS_FAST_CALL { m_double = d; }
@@ -317 +317 @@
         virtual RegisterID* emitCode(CodeGenerator&, RegisterID* = 0) KJS_FAST_CALL;
 
-        virtual bool isConstant() const KJS_FAST_CALL { return true; }
+        virtual bool isPure(CodeGenerator&) const KJS_FAST_CALL { return true; }
         virtual void streamTo(SourceStream&) const KJS_FAST_CALL;
         virtual Precedence precedence() const { return PrecPrimary; }
@@ -372 +372 @@
         virtual Precedence precedence() const { return PrecPrimary; }
 
+        virtual bool isPure(CodeGenerator&) const KJS_FAST_CALL;
         virtual bool isLocation() const KJS_FAST_CALL { return true; }
         virtual bool isResolveNode() const KJS_FAST_CALL { return true; }